From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Jan Blunck <jblunck@infradead.org>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] ethdev: cleanup device ops struct whitespace
Date: Thu, 22 Dec 2016 16:28:43 +0100 [thread overview]
Message-ID: <21208304.RglXy1FaaL@xps13> (raw)
In-Reply-To: <26b1177f-93c3-d3c3-fa63-e971af8dd139@intel.com>
2016-12-22 15:16, Ferruh Yigit:
> On 12/22/2016 3:10 PM, Jan Blunck wrote:
> > On Thu, Dec 22, 2016 at 2:10 PM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> >> - Grouped related items using empty lines
> >
> > Reordering fields of a struct is breaking ABI. We should bump the
> > library version now.
>
> You are right, sorry missed that.
> Intention was not to break the ABI, but cleanup.
>
> Thomas,
> If it is too late, do you want me prepare a revert patch?
No
Please check doc/guides/rel_notes/deprecation.rst
We are going to break the ethdev ABI anyway.
prev parent reply other threads:[~2016-12-22 15:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 13:59 [dpdk-dev] [PATCH] " Ferruh Yigit
2016-12-22 11:18 ` Thomas Monjalon
2016-12-22 11:53 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2016-12-22 12:46 ` Thomas Monjalon
2016-12-22 13:10 ` [dpdk-dev] [PATCH v3] " Ferruh Yigit
2016-12-22 15:00 ` Thomas Monjalon
2016-12-22 15:10 ` Jan Blunck
2016-12-22 15:16 ` Ferruh Yigit
2016-12-22 15:28 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21208304.RglXy1FaaL@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jblunck@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).