From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 31978A0545; Thu, 15 Dec 2022 14:37:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C1E7E40684; Thu, 15 Dec 2022 14:36:59 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 9D50E40223 for ; Thu, 15 Dec 2022 14:36:58 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 6CEC95C00D7; Thu, 15 Dec 2022 08:36:55 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 15 Dec 2022 08:36:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1671111415; x= 1671197815; bh=0Q/7qInO8dsgyAG/DKf6fjBoVfLh0Fv998M8iK7bqBU=; b=l RLhKS/0dxI1/x+76QmhNbmvaTp4E8quh3Q4lZSHAriW5/WBFtNiGAaZv4u5zdwTc etWXs3VL0W4ULwENBh7UuBqH72GAyZUppE7liH8VhE52OTJUOI/yI8oDPuQMKI1z iL9kp/rNw2GvR6VG7g+5d2LhMLnxkasZFxd0NmLksr6+4DQ8lx88PvQppPj2Ellv R0vht9E2vdxembyQUg66RMGDSQzWOugcb1wQrsEc6s0X1Lh617/aZbt7Q/Xm/YB+ LP2/rPQlciOjFfBfnYM0Cg67/5blSSY9Opwa/sj8PpLsbcUii+CwNpAnuoWha5Bu htNf75HpkfZErSrKcfYSw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1671111415; x= 1671197815; bh=0Q/7qInO8dsgyAG/DKf6fjBoVfLh0Fv998M8iK7bqBU=; b=D C2xagfJPrJhMb9zqdCveXt5EIWsj3Hn57Ad5BXHs7HrJhe4bB+ec3cIaVhXQz27p rtUcUs8aoXEJE4phIU254NJPgjWwThq2T1efyg6JjeB0onfjgaHoQbkOvKo9g4u5 cUr3hkUu9X26f7NTURTQBw4FJ4DATz2fVAsiaSrMEjNSvPgeDXaUmRtLvNtarxwJ M0F6dIRM6KYJRe2VgCi8kzbd/8UxwdKjeUVV9PolO7vRr0WEtHOAOchyJYtcfRs4 4BPVEjilB07Kqp5s5VEqTM7emXxrCdiHNH8ElY7iKvU3/A7WgMc268pzkFB9Rldb OzHu87GUul9yzaS8ulncw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeehgdehfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttddunecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepfefhjeeluedvvedtuddtuedtvefhieejtefhffeujefhteduudev tdektdeikeffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 15 Dec 2022 08:36:53 -0500 (EST) From: Thomas Monjalon To: Tyler Retzlaff , Bruce Richardson Cc: dev@dpdk.org, Morten =?ISO-8859-1?Q?Br=F8rup?= , david.marchand@redhat.com Subject: Re: [RFC PATCH 2/7] telemetry: add uint type as alias for u64 Date: Thu, 15 Dec 2022 14:36:51 +0100 Message-ID: <2122310.KiezcSG77Q@thomas> In-Reply-To: References: <20221213182730.97065-1-bruce.richardson@intel.com> <20221214173845.GC31935@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 15/12/2022 10:44, Bruce Richardson: > On Wed, Dec 14, 2022 at 09:38:45AM -0800, Tyler Retzlaff wrote: > > On Tue, Dec 13, 2022 at 06:27:25PM +0000, Bruce Richardson wrote: > > > For future standardization on the "uint" name for unsigned values rat= her > > > than the existing "u64" one, we can for now: > > > * rename all internal values to use uint rather than u64 > > > * add new function names to alias the existing u64 ones > > >=20 > > > Suggested-by: Morten Br=F8rup > > > Signed-off-by: Bruce Richardson > > > --- > > > lib/telemetry/rte_telemetry.h | 36 ++++++++++++++++++++++++++++++++= ++ > > > lib/telemetry/telemetry.c | 16 +++++++-------- > > > lib/telemetry/telemetry_data.c | 28 ++++++++++++++++++-------- > > > lib/telemetry/telemetry_data.h | 4 ++-- > > > lib/telemetry/version.map | 7 +++++++ > > > 5 files changed, 73 insertions(+), 18 deletions(-) > > >=20 > > > diff --git a/lib/telemetry/rte_telemetry.h b/lib/telemetry/rte_teleme= try.h > > > index c2ad65effe..60877dae0a 100644 > > > --- a/lib/telemetry/rte_telemetry.h > > > +++ b/lib/telemetry/rte_telemetry.h > > > @@ -8,6 +8,8 @@ > > > #ifndef _RTE_TELEMETRY_H_ > > > #define _RTE_TELEMETRY_H_ > > > =20 > > > +#include > > > + > > > #ifdef __cplusplus > > > extern "C" { > > > #endif > > > @@ -121,6 +123,22 @@ int > > > rte_tel_data_add_array_int(struct rte_tel_data *d, int x); > > > =20 > > > /** > >=20 > > when adding __rte_experimental api i have been asked to add the > > following boilerplate documentation block. i'm not pushing it, just > > recalling it is what i get asked for, so in case it's something we do? > > see lib/eal/include/rte_thread.h as an example > >=20 > >=20 > > ``` > > * @warning > > * @b EXPERIMENTAL: this API may change without prior notice. > > ``` > > >=20 > Ok, thanks for the notice. >=20 > Actually, related to this, since we are adding these functions as aliases > for existing stable functions, I would like to see these being added not = as > experimental. The reason for that, is that while they are experimental, we > cannot feasibly mark the old function names as deprecated. :-( >=20 > Adding Thomas and David on CC for their thoughts. Is it related to telemetry? In general, yes we cannot deprecate something if there is no stable replace= ment. The recommended step is to introduce a new experimental API and deprecate the old one when the new API is stable.