From: Thomas Monjalon <thomas@monjalon.net>
To: Hrvoje Habjanic <hrvoje.habjanic@zg.ht.hr>
Cc: "Singh, Jasvinder" <jasvinder.singh@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>, dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] rte_sched: correctly free allocated subport memory
Date: Thu, 25 Jun 2020 00:47:17 +0200 [thread overview]
Message-ID: <2123896.fl38WtTHKE@thomas> (raw)
In-Reply-To: <9e7ac418-f06a-3e3e-8883-c41d543f2755@zg.ht.hr>
30/05/2020 10:05, Hrvoje Habjanic:
> On 27. 05. 2020. 13:48, Singh, Jasvinder wrote:
> >>
> >> In function rte_sched_subport_free (lib/librte_sched/rte_sched.c, line 865),
> >> there is code to free all allocated stuff related to scheduler subport. First
> >> there are some checks, and in the end, rte_bitmap_free is called.
> >>
> >> Now, rte_bitmap_free is a dummy function, and it just checks if provided
> >> pointer to bitmap is valid or not. So, actual memory for subport is not freed.
> >>
> >> This patch fixes this by removing call to rte_bitmap_free, and instead calling
> >> rte_free.
> >>
> >> Signed-off-by: Hrvoje Habjanic <hrvoje.habjanic@zg.ht.hr>
> >> ---
> > Hi Hrvoje;
> >
> > I guess this is your first patch to dpdk.org, here are some suggestions when you send bug fixes;
>
> Yes, it is.
>
> >
> > - When sending fixes, please use "fix" word in the subject line, e.g- rte_sched: fix subport memory leak
> > - The commit message should include commit id corresponding to the line that you fixes as shown below for this case.
> > Fixes: d9213b829a31 ("sched: remove pipe params config from port level")
>
> OK, noted, thank you.
>
> > Patch looks good to me.
>
> Great.
>
> As s side note, it would be nice if this could be backported to 19.11 LTS.
Added Cc: stable@dpdk.org
> > Acked-by: Jasvinder Singh <jasvinder.singh@intel.com>
Applied, thanks
next prev parent reply other threads:[~2020-06-24 22:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 17:24 Hrvoje Habjanic
2020-05-27 11:48 ` Singh, Jasvinder
2020-05-30 8:05 ` Hrvoje Habjanic
2020-06-24 22:47 ` Thomas Monjalon [this message]
2020-05-29 5:48 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2123896.fl38WtTHKE@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=hrvoje.habjanic@zg.ht.hr \
--cc=jasvinder.singh@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).