From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F6D2A0350; Thu, 25 Jun 2020 00:47:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D08732B9E; Thu, 25 Jun 2020 00:47:23 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 85BE52B9C; Thu, 25 Jun 2020 00:47:21 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 0C4C05C00F7; Wed, 24 Jun 2020 18:47:21 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 24 Jun 2020 18:47:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= q73Hv9CUwro7TB7cSJO/SiGOG1W9cvwxBwdw5i2KPRg=; b=qJ8RF7WIbjYmtJZ5 n9ZSdHr6x5twFwHzMV3zrSR705CuiRBGESvc2YUJdzV41tSeWY6LIs1Xv70D2ndJ 7PpmSU3+DMvqPk7NtCcDSS95iw+zoFIvl3sNlAwhIroBHV+nOLyRdfR6n/lSvnmE FQT4KydLHjc+QHGPXl9lqtENAnVacv+hv3kTggF01nCKqT2sIRofedbrVjH5kgEJ ai5e9qFP1BFes1o8b52rIDHMMWM+eJEIFvN8+HnvYsliZWAfWk3J1FS33rj1UHFa pddWVFQM/MAk+26ySSa4kiafazR12p1GJZ2JB80W4SP+n8b6jBcSbCAqB+UZaNij HRTF1A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=q73Hv9CUwro7TB7cSJO/SiGOG1W9cvwxBwdw5i2KP Rg=; b=QpMmkKYmANE2reMTdLb7UiuVvhAf9iN/oo/9YvTIzAm4ndBKOrJnFkbEG O3lduYk5e7Hp0EXwHqVAK2Y0rdRpqY22nfPWpSNqH+7e4UEyb9fxYFDhMcV1yvTL E9OVOAnc1RzVSKzKNyIDlkgBpShDB4cvr95HEMx8m0Z1ygoQFEEwxW+0OCrxPr3h wOJEeH9dvbBYPq10N8nEQURYVJKuoXfLUEKUP7WeqVMOFXSw1RjFuIjVd/hHC5z1 rvyfIJQl+TlaT/BAjG5A74jWdYbHYOnrK26kfyp3j8HS9JQulVMSxm7poQMiJZRA zCY9mSCWOvMN7WAwpPxTLTkRpHsQg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudekkedgudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepffdvffejueetleefieeludduuefgteejleevfeekjeefieegheet ffdvkeefgedunecuffhomhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrd dvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6C1D9328005D; Wed, 24 Jun 2020 18:47:19 -0400 (EDT) From: Thomas Monjalon To: Hrvoje Habjanic Cc: "Singh, Jasvinder" , "dev@dpdk.org" , dpdk stable Date: Thu, 25 Jun 2020 00:47:17 +0200 Message-ID: <2123896.fl38WtTHKE@thomas> In-Reply-To: <9e7ac418-f06a-3e3e-8883-c41d543f2755@zg.ht.hr> References: <20200526172455.6457-1-hrvoje.habjanic@zg.ht.hr> <9e7ac418-f06a-3e3e-8883-c41d543f2755@zg.ht.hr> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] rte_sched: correctly free allocated subport memory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 30/05/2020 10:05, Hrvoje Habjanic: > On 27. 05. 2020. 13:48, Singh, Jasvinder wrote: > >> > >> In function rte_sched_subport_free (lib/librte_sched/rte_sched.c, line 865), > >> there is code to free all allocated stuff related to scheduler subport. First > >> there are some checks, and in the end, rte_bitmap_free is called. > >> > >> Now, rte_bitmap_free is a dummy function, and it just checks if provided > >> pointer to bitmap is valid or not. So, actual memory for subport is not freed. > >> > >> This patch fixes this by removing call to rte_bitmap_free, and instead calling > >> rte_free. > >> > >> Signed-off-by: Hrvoje Habjanic > >> --- > > Hi Hrvoje; > > > > I guess this is your first patch to dpdk.org, here are some suggestions when you send bug fixes; > > Yes, it is. > > > > > - When sending fixes, please use "fix" word in the subject line, e.g- rte_sched: fix subport memory leak > > - The commit message should include commit id corresponding to the line that you fixes as shown below for this case. > > Fixes: d9213b829a31 ("sched: remove pipe params config from port level") > > OK, noted, thank you. > > > Patch looks good to me. > > Great. > > As s side note, it would be nice if this could be backported to 19.11 LTS. Added Cc: stable@dpdk.org > > Acked-by: Jasvinder Singh Applied, thanks