From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4B380A034C; Wed, 21 Sep 2022 09:29:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D103A40697; Wed, 21 Sep 2022 09:29:47 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 4A25A4014F for ; Wed, 21 Sep 2022 09:29:46 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 02FD35C003D; Wed, 21 Sep 2022 03:29:46 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 21 Sep 2022 03:29:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1663745386; x= 1663831786; bh=3xz54xe2Teci8kMWYpDom30+wIRPANQt4dqZNFEKUSo=; b=f EqEy0+r8NMXGEmWATND1DHZG3RJUlSfg7zZc/BlXTacqcKpAq8kiG7IIpV06Dpez GFRR96NMv0HHQ//hsYuXg98m7LyjPywWf5+jVgQasY/hToewto6Qb2ANOOYCLyVO NhiWX7gt0dgExpqKwbANW4Rywq5IkF5qf7mB8qLhFl1ruekIM7DsNbWMkARetnsZ t/yoOBNnFKclzDN0tMul4BKY14PP41AAGSwvMyqAQO6BQlb58ptsR8yJjKjzZveb V6/BYcq8ZtxIwB4jjORdIadD1vGWcrPgMj++VNG9DzyjZvAL3NZgGWQuD5OiMV4s M/9bVbuxeD5b/De/by9CA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1663745386; x= 1663831786; bh=3xz54xe2Teci8kMWYpDom30+wIRPANQt4dqZNFEKUSo=; b=k mSGQP50TAQEsMO9iUU6V77YMJsk7VCXk4pEHshRXnseKVsFChaOKJaXdhmgNxSfG L9aWG61g5WyDyxdEgTPvrLgWjBvwIxYDWX729EtCIoQF3z9rCQPaBHHHG+ZobTEL EUXB414Z7CcBLv3rO4sIDrgGjblCvdCrj1KoXcM/ANYV/9f0gzTlfANnrE2TDPh0 wPhqY77SKjvt/OQ2mIEfOiA9TS9U9i8mqUWNJ3rE+IKB7ZpncKbCbOrMaZE6eASo c8VTF8rsUx7WyokhF4ff8czuv/PPkGduk+CpFGxmJ4LCReTjlO82tXVF6UtQsG9u kmuTopqFWR0t1mx6IlJ8A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeftddguddvfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttddunecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnhepfefhjeeluedvvedtuddtuedtvefhieejtefhffeujefhtedu udevtdektdeikeffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 21 Sep 2022 03:29:44 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit , "dev@dpdk.org" , Chaoyong He Cc: oss-drivers , Niklas Soderlund , Jerin Jacob Kollanukkaran , Andrew Rybchenko , David Marchand Subject: Re: [PATCH v9 07/12] net/nfp: add flower ctrl VNIC related logics Date: Wed, 21 Sep 2022 09:29:43 +0200 Message-ID: <2126161.Icojqenx9y@thomas> In-Reply-To: References: <1663238669-12244-1-git-send-email-chaoyong.he@corigine.com> <30e1463b-22c6-cd26-acf3-c38c05ea477b@xilinx.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 21/09/2022 04:02, Chaoyong He: > > On 9/15/2022 11:44 AM, Chaoyong He wrote: > > > Adds the setup/start logic for the ctrl vNIC. This vNIC is used by the > > > PMD and flower firmware application as a communication channel > > between > > > driver and firmware. In the case of OVS it is also used to communicate > > > flow statistics from hardware to the driver. > > > > > > A rte_eth device is not exposed to DPDK for this vNIC as it is > > > strictly used internally by flower logic. > > > > >=20 > > Hi Chaoyong, > >=20 > > Similar comment with previous versions, interface is created using regu= lar > > 'rte_eth_dev_allocate()' API, I think interface will be visible to appl= ication, I > > can't understand the need of creating an interface for control. You didn't reply to this. Why the control port should be exposed to the application? We recommend not using ethdev for this. > > What is the communication method between driver and FW? > > Since one of the following patches (09/12) introduces Rx/Tx for ctrl in= terface, > > is device interface is control packets (similar to network data packets= )? > >=20 >=20 > Basically, the 'control message' is exist in the form of normal data pack= ets. >=20 > When we use the flower firmware application, there exist two types of pac= kets for now, > and they are identified only from the prepend meta-data. >=20 > Bit 3 3 2 2 2 2 2 2 2 2 2 2 1 1 1 1 1 1 1 1 1 1 0 0 0 0 0 0 0 0 0 0 > -----\ 1 0 9 8 7 6 5 4 3 2 1 0 9 8 7 6 5 4 3 2 1 0 9 8 7 6 5 4 3 2 1 0 > Word +---------------+---------------+---------------+---------------+ > 0 | type | type | type | type | > +---------------+---------------+---------------+---------------+ > The 'control message' packets are processed by the ctrl vNIC. > The 'normal' packets are processed by the pf vNIC. >=20 > The communication method between driver and firmware is decided by the > designment of hardware and firmware. >=20 > The kernel driver also has the same ctrl vNIC and pf vNIC ethdev and the = usage is same. >=20 > > > Because of the add of ctrl vNIC, a new PCItoCPPBar is needed. Modify > > > the related logics. > > > > > > Signed-off-by: Chaoyong He > > > Reviewed-by: Niklas S=F6derlund