* [dpdk-dev] [PATCH] app/testpmd: fix help string for port reset
@ 2021-07-23 12:24 Ferruh Yigit
2021-07-23 19:36 ` Andrew Rybchenko
0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2021-07-23 12:24 UTC (permalink / raw)
To: Xiaoyun Li, Wei Dai, Jingjing Wu; +Cc: Ferruh Yigit, dev, stable
Command help string is missing 'reset' keyword, although description has
it. Adding it.
Fixes: 97f1e196799f ("app/testpmd: add port reset command")
Cc: stable@dpdk.org
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: wei.dai@intel.com
---
app/test-pmd/cmdline.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 8468018cf35d..905a6143eb0e 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -1237,7 +1237,7 @@ cmdline_parse_token_string_t cmd_operate_port_all_all =
cmdline_parse_inst_t cmd_operate_port = {
.f = cmd_operate_port_parsed,
.data = NULL,
- .help_str = "port start|stop|close all: Start/Stop/Close/Reset all ports",
+ .help_str = "port start|stop|close|reset all: Start/Stop/Close/Reset all ports",
.tokens = {
(void *)&cmd_operate_port_all_cmd,
(void *)&cmd_operate_port_all_port,
@@ -1284,7 +1284,7 @@ cmdline_parse_token_num_t cmd_operate_specific_port_id =
cmdline_parse_inst_t cmd_operate_specific_port = {
.f = cmd_operate_specific_port_parsed,
.data = NULL,
- .help_str = "port start|stop|close <port_id>: Start/Stop/Close/Reset port_id",
+ .help_str = "port start|stop|close|reset <port_id>: Start/Stop/Close/Reset port_id",
.tokens = {
(void *)&cmd_operate_specific_port_cmd,
(void *)&cmd_operate_specific_port_port,
--
2.31.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] app/testpmd: fix help string for port reset
2021-07-23 12:24 [dpdk-dev] [PATCH] app/testpmd: fix help string for port reset Ferruh Yigit
@ 2021-07-23 19:36 ` Andrew Rybchenko
2021-07-24 9:07 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Rybchenko @ 2021-07-23 19:36 UTC (permalink / raw)
To: Ferruh Yigit, Xiaoyun Li, Wei Dai, Jingjing Wu
Cc: dev, stable, Thomas Monjalon
On 7/23/21 3:24 PM, Ferruh Yigit wrote:
> Command help string is missing 'reset' keyword, although description has
> it. Adding it.
>
> Fixes: 97f1e196799f ("app/testpmd: add port reset command")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] app/testpmd: fix help string for port reset
2021-07-23 19:36 ` Andrew Rybchenko
@ 2021-07-24 9:07 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2021-07-24 9:07 UTC (permalink / raw)
To: Ferruh Yigit
Cc: Xiaoyun Li, Wei Dai, Jingjing Wu, dev, stable, Andrew Rybchenko
23/07/2021 21:36, Andrew Rybchenko:
> On 7/23/21 3:24 PM, Ferruh Yigit wrote:
> > Command help string is missing 'reset' keyword, although description has
> > it. Adding it.
> >
> > Fixes: 97f1e196799f ("app/testpmd: add port reset command")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-24 9:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-23 12:24 [dpdk-dev] [PATCH] app/testpmd: fix help string for port reset Ferruh Yigit
2021-07-23 19:36 ` Andrew Rybchenko
2021-07-24 9:07 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).