From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id F30617CDA
 for <dev@dpdk.org>; Wed, 21 Mar 2018 21:32:34 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 5A69B21254;
 Wed, 21 Mar 2018 16:32:34 -0400 (EDT)
Received: from frontend2 ([10.202.2.161])
 by compute1.internal (MEProxy); Wed, 21 Mar 2018 16:32:34 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=ogBvcg7v6hMSRQe6yPtMGrjKfx
 5J5RHNyC3othtNXtE=; b=Jmf9Iji0q9rhwM3Ur+E+QaWrpzfLbZ2N5KnqVc8Bsu
 J83x8cwYlkxQ2d4hWbt4qmkYEg7G4n4Cia8drfIiW43kW3jzqXF6OvzaI/WB2q5E
 4gqXJPkxdzerwf1kjG0SI56tT1KRBP3xJy43bba5DjUsSa7YYo0Od24BtPG0j4GT
 k=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=ogBvcg
 7v6hMSRQe6yPtMGrjKfx5J5RHNyC3othtNXtE=; b=lAW7pUL7E7iddzEEOwLYHw
 6gy35g3WfF3XmXRV6vBizuHrMYwdaFFjPUHpDsdOMYuXQ8qn6nJG2udlgbIvBx4D
 eugCuMoyaEvoAJVNnIyzk3y9MfDlvjAviDZt/bteWzvYcc/OblKu6sqPQlxyj5cs
 8p2zTMCkQ4uonv2+7HeSx0zuR94BWB1TcUr1kFfsDlal81KxCNIiwURrJ0AwmhRs
 nxnH9uRyEspGbIeLjKtp4lJmhKWmBjqp27pRo4ejEa29M8Gs2wrce0Y6YaF7rFwl
 3Zs44sxPg8HuMP/chPthqbKRx8QrOev4kIyxItFCIJeBMqb6QmlvY8v0t5PJfVZA
 ==
X-ME-Sender: <xms:YsGyWkTaf7vRHDDHqQL28LUfZjbuWRCIQENZmUOuaS5mxH2yQfiK1A>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id F060B24149;
 Wed, 21 Mar 2018 16:32:32 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Xiao Wang <xiao.w.wang@intel.com>, junjie.j.chen@intel.com
Cc: dev@dpdk.org, maxime.coquelin@redhat.com, yliu@fridaylinux.org,
 zhihong.wang@intel.com, tiwei.bie@intel.com, rosen.xu@intel.com,
 dan.daly@intel.com, cunming.liang@intel.com, anatoly.burakov@intel.com,
 gaetan.rivet@6wind.com
Date: Wed, 21 Mar 2018 21:32:18 +0100
Message-ID: <2126445.Z7b39kXXoB@xps>
In-Reply-To: <20180321132108.52464-2-xiao.w.wang@intel.com>
References: <20180309230809.63361-3-xiao.w.wang@intel.com>
 <20180321132108.52464-1-xiao.w.wang@intel.com>
 <20180321132108.52464-2-xiao.w.wang@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2 1/3] eal/vfio: add support for multiple
	container
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Mar 2018 20:32:35 -0000

Hi,

21/03/2018 14:21, Xiao Wang:
> +#endif /* VFIO_PRESENT */
>  #endif /* _RTE_VFIO_H_ */

Please keep the empty line which was present between endif.

> +	rte_vfio_create_container;
> +	rte_vfio_destroy_container;
> +	rte_vfio_bind_group_no;
> +	rte_vfio_unbind_group_no;
> +	rte_vfio_dma_map;
> +	rte_vfio_dma_unmap;
> +	rte_vfio_get_group_fd;

Please keep alphabetical order.

About the naming, I see "no" and "idx" are used.
Other APIs in DPDK are using "num" and "id". Any strong opinion?