From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F2CCA0521; Tue, 3 Nov 2020 18:21:51 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8B8AE2BFF; Tue, 3 Nov 2020 18:21:49 +0100 (CET) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by dpdk.org (Postfix) with ESMTP id E350728EE; Tue, 3 Nov 2020 18:21:46 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 26ADCCB7; Tue, 3 Nov 2020 12:21:44 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 03 Nov 2020 12:21:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= s2RZog5X4DlFzHwuL0Zu4mphv+quqfWiWMQt7ho1QpI=; b=sDK8b/IRkO3+wnuI 4kM56tC3oZneOtEQuH7OLSbhj25lHLWgZup6Rypv4CU+Amg38KRwFsbpVsyMX49H wMzulCzHQOSqGnYZKMetOTSn8YK9tPKEcu8VQNRrVAcEMinAgqdkkpcrHTM+B9ZE R6lI5XZa3oP39eEpINYM9amCpPX5YhiM1bAZbGr6i5ENA7E4ML6TJCuaKJADX8md yYM6Na/iAY/1PmB+OqAFuOtZwFroEkLjFEJmXLr4ti1yQbb/KI/o7IY+t4Iqfmlr nwiOcr2TH0ITZReerzei54Gy6o86+qo3cWmUs39hd3HIkf4EvoU/bffIkLY6QkYK 8CVV+Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=s2RZog5X4DlFzHwuL0Zu4mphv+quqfWiWMQt7ho1Q pI=; b=hB39lQBIiVfYqhb7RWQKqhobThBzfzcAykb9RI5s30bRtGrlwJL3WSgay gYQry9hWDDanX3s9voVFqAKdzUzCU9xqfsBwcy2G2fJBB5/WrfePD5Hf0CwNvKIQ SnDRmuRLaLtoRb+LjHw0fqkEQQNB7vBXO0JAo7KfuaESvY78to+RE60XT5gGgah8 rjphRkivP+e5J0qOWDqx+rWTc5y8nadBz3uO32qyiZoq9PU7WgcRcb0rY7ABQZ05 CpnZQYBvO7glMhcChCcHkUGIzQCHU5fIOcpDnIOZcN4CttF7F0AIS33tzC1rQbTR 4WsHpev61A2jzD1zoxgxyf/PRKhNw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddtfedgleekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id EAA11328005D; Tue, 3 Nov 2020 12:21:40 -0500 (EST) From: Thomas Monjalon To: Andrew Rybchenko , Ori Kam Cc: dev@dpdk.org, Andrew Rybchenko , Andrey Vesnovaty , Ferruh Yigit , Ray Kinsella , Neil Horman , techboard@dpdk.org Date: Tue, 03 Nov 2020 18:21:38 +0100 Message-ID: <2129017.0sQ5Lg8UGW@thomas> In-Reply-To: References: <1603961577-13264-1-git-send-email-arybchenko@solarflare.com> <2047036.ch1fFInd6B@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ethdev: deprecate shared counters using action attribute X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" +Cc techboard There is an interesting case here that we should decide how to manage in general. Please see below. 01/11/2020 08:49, Ori Kam: > From: Thomas Monjalon > > 29/10/2020 15:39, Ori Kam: > > > > struct rte_flow_action_count { > > > > - uint32_t shared:1; /**< Share counter ID with other flow rules. */ > > > > + /** @deprecated Share counter ID with other flow rules. */ > > > > + uint32_t shared:1; > > > > uint32_t reserved:31; /**< Reserved, must be zero. */ > > > > uint32_t id; /**< Counter ID. */ > > > > }; > > > > > > As much as I agree with your patch, I don't think we should push it since > > > not all PMD made the move to support count action, so the application still > > needs > > > to use this API. > > > > > > I think this patch should be done but in next LTS release. > > > > The patch is not removing the field, > > it is just warning it will be removed in next year. > > Yes I know, but I don't think it is correct to issue such a warning without support. > The application still must use this API, the warning should be added as soon as > at least one PMD support shared counters with the new API. It should be replaced with shared actions API, but you claim it is not supported yet. Right? What are the criterias to define the replacement as supported? What to do in such case? Can we warn about a deprecation without having a proper replacement? What is the pre-condition to warn about a deprecation? About the complete removal, it has already been decided by the techboard that we cannot remove an API until its replacement is stable. In other words, the new experimental API must be promoted in the stable ABI, before removing the deprecated API.