* [dpdk-dev] [PATCH] aesni_gcm: fix incorrect supported key sizes
@ 2016-04-06 15:39 Pablo de Lara
2016-04-06 16:29 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Pablo de Lara @ 2016-04-06 15:39 UTC (permalink / raw)
To: dev; +Cc: declan.doherty, Pablo de Lara
AES-GCM PMD only supports 128-bit keys, but not 192 and 256,
which the capabilities structure was reporting.
Fixes: 27cf2d1b18e1 ("examples/l2fwd-crypto: discover capabilities")
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
drivers/crypto/aesni_gcm/aesni_gcm_pmd_ops.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/crypto/aesni_gcm/aesni_gcm_pmd_ops.c b/drivers/crypto/aesni_gcm/aesni_gcm_pmd_ops.c
index 4dec8dd..e824d4b 100644
--- a/drivers/crypto/aesni_gcm/aesni_gcm_pmd_ops.c
+++ b/drivers/crypto/aesni_gcm/aesni_gcm_pmd_ops.c
@@ -48,8 +48,8 @@ static const struct rte_cryptodev_capabilities aesni_gcm_pmd_capabilities[] = {
.block_size = 16,
.key_size = {
.min = 16,
- .max = 32,
- .increment = 8
+ .max = 16,
+ .increment = 0
},
.digest_size = {
.min = 8,
@@ -73,8 +73,8 @@ static const struct rte_cryptodev_capabilities aesni_gcm_pmd_capabilities[] = {
.block_size = 16,
.key_size = {
.min = 16,
- .max = 32,
- .increment = 8
+ .max = 16,
+ .increment = 0
},
.iv_size = {
.min = 16,
--
2.5.5
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] aesni_gcm: fix incorrect supported key sizes
2016-04-06 15:39 [dpdk-dev] [PATCH] aesni_gcm: fix incorrect supported key sizes Pablo de Lara
@ 2016-04-06 16:29 ` Thomas Monjalon
2016-04-06 17:05 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2016-04-06 16:29 UTC (permalink / raw)
To: Pablo de Lara; +Cc: dev, declan.doherty
2016-04-06 16:39, Pablo de Lara:
> AES-GCM PMD only supports 128-bit keys, but not 192 and 256,
> which the capabilities structure was reporting.
>
> Fixes: 27cf2d1b18e1 ("examples/l2fwd-crypto: discover capabilities")
I think you mean
Fixes: 26c2e4ad5ad4 ("cryptodev: add capabilities discovery")
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] aesni_gcm: fix incorrect supported key sizes
2016-04-06 16:29 ` Thomas Monjalon
@ 2016-04-06 17:05 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2016-04-06 17:05 UTC (permalink / raw)
To: Pablo de Lara; +Cc: dev, declan.doherty
2016-04-06 18:29, Thomas Monjalon:
> 2016-04-06 16:39, Pablo de Lara:
> > AES-GCM PMD only supports 128-bit keys, but not 192 and 256,
> > which the capabilities structure was reporting.
> >
> > Fixes: 27cf2d1b18e1 ("examples/l2fwd-crypto: discover capabilities")
>
> I think you mean
> Fixes: 26c2e4ad5ad4 ("cryptodev: add capabilities discovery")
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-06 17:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-06 15:39 [dpdk-dev] [PATCH] aesni_gcm: fix incorrect supported key sizes Pablo de Lara
2016-04-06 16:29 ` Thomas Monjalon
2016-04-06 17:05 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).