From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 277F61BBE7 for ; Thu, 20 Dec 2018 12:36:18 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B2F7B22131; Thu, 20 Dec 2018 06:36:17 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 20 Dec 2018 06:36:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=lT05+5pNWCt7dpmHrP0fcQJxLYJA8b0cljEcRl2+xqA=; b=IaXpik3KZdPx eAgEOzWOP2H4ujrd7nSsf8+6JiK54z8QI+ZmSm4lkAP0TtSm+y/1RfWxTzpltaRD S7tUbkAN0bVU4UsEgwL+8RuGZfVdrHo+30pgWwGyGHNx+qBJUrW746yr80nccuqu hM/YY501Z2Q+mp8POkHvy8CJzgb/imk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=lT05+5pNWCt7dpmHrP0fcQJxLYJA8b0cljEcRl2+x qA=; b=b7M/MnX9YLkmmyFa9DCCwKCv4VB3rMEEWAy2qScTLBZotCyzPDxcu4qVz wgizwq/MG+uSpVpLoZqFe9rAug1j12g3SrdGz5x2/LYYb2sihCNxoe9Um3ATf/K9 vC6YXryEGu5p+Pry3jLx7EbRt5OEDEfg6VhgV8qRwE7rfEEe0GRHh/OrIzeJ4fH8 IlVT9QYpOUZovPvTk1RWJ6mD5Uxo8cWiwdc6Zbcj0T+paAqM7S5oZr3RiS4ZRzLu KauX23G7PtLzr0Z3rdLAmhsX199J3dH2/NftPn2GVK/0D7dNwuFknPjTK8DO1Anf 4DsFi9mHMRJggD3LS4lxp0NCRDMCQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtkedrudejfedgfeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufffkjg hfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcu oehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtd efrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A27C7E4366; Thu, 20 Dec 2018 06:36:15 -0500 (EST) From: Thomas Monjalon To: Gao Feng Cc: Gao Feng , dev@dpdk.org, "Burakov, Anatoly" Date: Thu, 20 Dec 2018 12:36:14 +0100 Message-ID: <2129438.97vpQxbemm@xps> In-Reply-To: <1849368.QYu7HmPSto@xps> References: <1544057251-17351-1-git-send-email-gfree.wind@vip.163.com> <1849368.QYu7HmPSto@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] eal: fix unlock in rte_eal_memzone_init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Dec 2018 11:36:18 -0000 20/12/2018 12:20, Thomas Monjalon: > 07/12/2018 09:57, Burakov, Anatoly: > > On 07-Dec-18 1:20 AM, Gao Feng wrote: > > > The RTE_PROC_PRIMARY error handler lost the unlock statement in the > > > current codes. Now unlock and return in one place to fix it. > > > > > > Fixes: 49df3db84883 ("memzone: replace memzone array with fbarray") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Gao Feng > > > --- > > Acked-by: Anatoly Burakov > > Applied, thanks > > I changed your author email (From:) to match the Signed-off-by one. > Please configure your git to use the Tencent email if possible. > Note you can have a "git From" address and use another one for sending. One more tip about patch formatting: I reworded the title to: memzone: fix unlock on initialization failure The prefix "memzone" gives the scope of the change. We decided that memzone is important enough to have its own scope prefix. You can find other prefixes in the git history. Then the rest of the title is written in plain english, detailing more the scope with "on initialization failure". Hope it helps, and welcome :)