From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f180.google.com (mail-wr0-f180.google.com [209.85.128.180]) by dpdk.org (Postfix) with ESMTP id 17564559A for ; Mon, 10 Apr 2017 22:58:26 +0200 (CEST) Received: by mail-wr0-f180.google.com with SMTP id o21so128463240wrb.2 for ; Mon, 10 Apr 2017 13:58:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=zmjpwdEoFsYWOkES0qzMZhe+vsME+HFP7oQTjP95n7M=; b=P6xYAT8dHiCxpBXoL3rexLaSrN8emJq6eOXHx8CWN+E9HG1bqKI+qQRBfQ7FniXf82 GU8CaW5HOUjXYWyuBs+wnJSlgNMA0aM1kqvNU2q/+sFKxSwDO0kDmw8olvz5/7+WLL7N DdaQSBCiChTcq8ZIjhrfs/WjXmHSPo6E48wHULnqWdHAH6/bvTmD0yaq//VlIPIln4fC LU0uYdheDxYMwYD9d5/UIicy/KiSeLfvqhGsHCLjz2tdksCa2oOYMkSFalhJeboWLVsm 282Y3HU20K9gHMoJ6iglWJYps7lhSoUKdwbnDBlcGF/QqK2Hki40TBkJ3QdnpswdkTdh xxrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=zmjpwdEoFsYWOkES0qzMZhe+vsME+HFP7oQTjP95n7M=; b=nwu67LJv2czQ5Z+ZiQY1oLYnxXI2zKXd1Fvbr0envh32GxQCkgWLOkXXfjfTAM+Rn4 f67O1GHWKPC/RAH+ygkvGsAkA9I7o1UdoEhCVfZy06Da/Ab6KEbb0DxXeM9T5qU+yGDB BAHpVCD7JhgZbngvRBAjAY7c4/+nGPIkilGZCH/C+uX/AvuJhf6obcG+RcM5ii0y/4RO aSeFQjRgfu12EtfmPQbMfat5SJvTFNCWE0DIWW3TjSURYtA5RWLDPHVKJWzW2X3KWesy VFY3oMdezuAn6EYJj0ln7114B0mLBjyddGbj+OAvhnF5b8MFy+V2RiSLadP1K22m1Ocp p84g== X-Gm-Message-State: AFeK/H14JJZIeTdBxiOxLo07pwABh8YvjkCGjWTjBQnykJYveaHgg8mVd5TCD8H4vBGlREaN X-Received: by 10.223.176.202 with SMTP id j10mr32579086wra.10.1491857906741; Mon, 10 Apr 2017 13:58:26 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id m201sm11693567wmd.15.2017.04.10.13.58.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 10 Apr 2017 13:58:26 -0700 (PDT) From: Thomas Monjalon To: "Zhao1, Wei" Cc: "Ananyev, Konstantin" , "Mcnamara, John" , dev@dpdk.org, "Lu, Wenzhuo" Date: Mon, 10 Apr 2017 22:58:25 +0200 Message-ID: <21313321.HHiDCuvJPv@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <2601191342CEEE43887BDE71AB9772583FAE5871@IRSMSX109.ger.corp.intel.com> References: <1490866456-52241-1-git-send-email-wei.zhao1@intel.com> <2601191342CEEE43887BDE71AB9772583FAE5871@IRSMSX109.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 1/3] lib/librte_ether: add support for port reset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Apr 2017 20:58:27 -0000 2017-04-06 09:02, Ananyev, Konstantin: > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhao1, Wei > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > 2017-04-06 02:57, Zhao1, Wei: > > > > > /** > > > > > > + * Reset an ethernet device when it's not working. One scenario > > > > > > + is, after PF > > > > > > + * port is down and up, the related VF port should be reset. > > > > > > + * The API will stop the port, clear the rx/tx queues, re-setup > > > > > > + the rx/tx > > > > > > + * queues, restart the port. > > > > > > > > > > s/The API/This function/ > > > > > > > > > > Please explain exactly the responsibility of this function, and how > > > > > it is different from calling stop/configure/start. > > > > > > > > In this reset feature, reset function can do the calling > > > > stop/configure/start process, but also It can also do some restore > > > > work for the port, for example, it can restore the added parameters of > > > vlan, mac_addrs, promisc_unicast_enabled falg and > > > promisc_multicast_enabled flag. > > Ok, but why start/stop can't do these things? Please could you try to answer this question? We cannot accept v7 if there are some doubts remaining.