From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id ED1C81B81F for ; Wed, 25 Oct 2017 12:12:58 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4922D22776; Wed, 25 Oct 2017 06:12:58 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Wed, 25 Oct 2017 06:12:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=oc8zIX8+ida/LGALroq+ACNSFd 5FJJfcr4JjzM+M01o=; b=LLoEDp2x3XtEyLPG9knPaO8K+wcRLCLVEusMSI/v5l 8xSGVu8HGw6OArM2i4W9AjM2QXhAoG2LJQwqWDYP1/tnUm0DSDOjjZanxP/Ci11Q hkjinAdSRyNMMDJsbmi9tLWIxZXkg/kpVHdN7u7nLBrmaeIdaQz9FNCojeobbe28 U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=oc8zIX 8+ida/LGALroq+ACNSFd5FJJfcr4JjzM+M01o=; b=VL6rViWtN8VE3E7Uw3+AsZ 8ug4KU97Vov5RZ5qnv/JG4QzZBxJbaTpxh14EK+RmQhsIgM/3vkEzCWpuS1OCZ6W 6m6Hfv8sOhjpqiB0sKV5Cpv63LAHr6QQ/opPMQ+ISm14UAwIpZ9+hJOuaqsu1W88 RrhPK9w8zCZFJul6zheT/wukdq6zSyeM7SqZ5BvsNMNRPlTPB06dgtgVkzkLRWLr pL/la5SKJ4sJr2P0v8OXzXJkUmSaOW26z7na0TwmsmkLIga2dZUL/CkyaMLQmZWp UArdgR5PSQV2aw/9aKo8Pu7tX2i2mu6ScaOFSgsFEQuj1Ii0quAD8FmRnfxlyqbw == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id EDB4124B26; Wed, 25 Oct 2017 06:12:57 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: santosh , dev@dpdk.org, "olivier.matz@6wind.com" , "jerin.jacob@caviumnetworks.com" , "hemant.agrawal@nxp.com" , "Burakov, Anatoly" Date: Wed, 25 Oct 2017 12:12:57 +0200 Message-ID: <2132580.mYdmqLBblI@xps> In-Reply-To: <20171025100545.GA11132@bricha3-MOBL3.ger.corp.intel.com> References: <20170905103119.20511-1-santosh.shukla@caviumnetworks.com> <1726043.3urDsTveGQ@xps> <20171025100545.GA11132@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 5/6] doc: remove dpdk iova aware notice X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2017 10:12:59 -0000 25/10/2017 12:05, Bruce Richardson: > On Wed, Oct 25, 2017 at 12:01:26PM +0200, Thomas Monjalon wrote: > > 25/10/2017 11:50, Richardson, Bruce: > > > From: Thomas Monjalon > > > > > On Tuesday 24 October 2017 01:59 AM, Thomas Monjalon wrote: > > > > > > 20/10/2017 14:31, Santosh Shukla: > > > > > >> Removed dpdk iova aware ABI deprecation notice, and updated ABI > > > > > >> change details in release_17.11.rst. > > > > > >> > > > > > >> Signed-off-by: Santosh Shukla > > > > > >> Acked-by: John McNamara > > > > > >> --- > > > > > >> --- a/doc/guides/rel_notes/deprecation.rst > > > > > >> +++ b/doc/guides/rel_notes/deprecation.rst > > > > > >> -* eal: An ABI change is planned for 17.11 to make DPDK aware of > > > > > >> IOVA address > > > > > >> - translation scheme. > > > > > >> - Reference to phys address in EAL data-structure or functions may > > > > > >> change to > > > > > >> - IOVA address or more appropriate name. > > > > > >> - The change will be only for the name. > > > > > >> - Functional aspects of the API or data-structure will remain same. > > > > > > Sorry, this series cannot be applied as is because it is breaking > > > > > > more than EAL API. The API of mbuf and mempool are also changed. > > > > > > We need to choose one of these three options: > > > > > > 1/ accept to break all API in 17.11 > > > > > > 2/ postpone the whole series to 18.02 > > > > > > > > > > Theme of series is to make dpdk iova aware so I would prefer option 1) > > > > or 2). > > > > > However I have no strong opinion on this topic. > > > > > Lets get more opinion from others about option 1/2/3. > > > > > > > > > > > 3/ rename only EAL API in 17.11 and postpone mbuf/mempool > > > > > > > > After discussing with Olivier it appeared there is a fourth solution. > > > > We should not break any API (EAL, mbuf, mempool). > > > > > > > > I would like to merge these changes in RC2, but keeping compatibility with > > > > old names: > > > > - When you rename a function or a type, you can define a macro for the old > > > > name, alias the new name. > > > > > > Note: using a macro doesn't prevent the ABI being broken if you rename a public function. You'll need to use function versioning too. > > > > True > > We can use an inline function to avoid ABI breakage. > > Nope, inline function won't work either, since that ends up the same as > the macro and compiled into the end app, not the library ABI. You > need a public non-inline wrapper function to keep ABI, or else function > renaming via symbol versioning/mapping. Ah ah ah, I'm writing before thinking :) Yes, the function must not be inlined. And generally speaking it is not an issue, even for performance critical functions. Adding one more function call in the path is not a bad thing for deprecated functions. I've seen another project (don't remember which one) adding a sleep() in deprecated functions and increasing the sleep time at each new release :)