Re: [dpdk-dev] [PATCH v5 4/8] Move common functions in eal_timer.c

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2015-04-09 12:40, Ravi Kerur:
> Changes in v5
> Rebase to latest code.
> 
> Changes in v4
> Removed extern declaration of eal_tsc_resolution_hz,
> instead provided _set_ API.
> Make set_tsc_freq_from_clock as wrapper function for BSD.
> 
> Changes in v3
> Changed subject to be more explicit on file name inclusion.
> 
> Changes in v2
> Use common function name set_tsc_freq_from_sysctl for BSD and Linux.
> Update comments about its actuality in function declaration.
> 
> Changes in v1
> Move common functions in eal_timer.c to librte_eal/common/
> eal_common_timer.c file.
> 
> Following functions are  moved to eal_common_timer.c file
> 
> void rte_delay_us(unsigned us);
> uint64_t rte_get_tsc_hz(void);
> static void set_tsc_freq_fallback(void);
> void set_tsc_freq(void);
> 
> Makefile changes to reflect new file added.
> Fix checkpatch warnings and errors.
> 
> Signed-off-by: Ravi Kerur <rkerur@gmail.com>

Seems good.
Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Minor nit, a blank line is missing:
> + *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> + */
> +#include <string.h>