From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9926FA0C43; Tue, 14 Sep 2021 15:59:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5F8474068F; Tue, 14 Sep 2021 15:59:46 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 765574068F; Tue, 14 Sep 2021 15:59:45 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E2EFC5C039C; Tue, 14 Sep 2021 09:59:43 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 14 Sep 2021 09:59:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= LSUD/1cWjDaqVF5fkvHOvVtG82EqtPDtZALlad1kp2Q=; b=I6FbQGQnmB78DSPq kFdpQo0pyOp3OQlCluniFWoaG1W2j5T3PldO25c2pzQzF1C/Bjo712UNK1tyXWv5 Og3K0NIwxAcSAXLHb+1T3yFYi/edEkOh7Vueuf/xypzw8+yOlDdJ2wKvtsWXicyw tjnV0zxLWWQBa6xOrg4HFuwsCIxBSQ1xGx0n519FqhV9Li0EVzNku9Ruoysb7vAe oPpiYCbLRqpu9bpMu39mX0BU1EI/5jdOelDocdcXYyMX1uy5FX8XdzNnX1nGHbCj DfAwEY/SC9r0dOJytRKowfE6ejyTR12GTHXwI/bdfuhfipjq1M/MAR5fcNUozs26 7yNUJw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=LSUD/1cWjDaqVF5fkvHOvVtG82EqtPDtZALlad1kp 2Q=; b=JuKM5jupWCkODlRt3966sfwRuDCkLHeF/YBY8tsMx2Af2li+TKSJQwODM X0WOgFMGnbQDmzsZabX8UYnFzLOyC++5oZi8LVA8zbPJmwsi6HTt+1nPxgCcy3s2 +7isHwLM6thP8sG/tWtZiIkFpsDlt8JFlljCyzwJLWT09ujoP4T8IDZvaNqWkf2a 6g9b8fz40VwPi6QVSYomLErCIRDOhHgLn3MUzhXhI/B5o/i8KSY4ACmlZlc5w7b8 C8X4O2Jt16LVqCOuAOId64RCeO1+fs26RGUKIKX5/t/1DiDsLqznJ1+hpccfSJrx kLKiPn6RxPniVOI8uFJ1bBV4qLGLg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudegledgjedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 14 Sep 2021 09:59:42 -0400 (EDT) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: dev@dpdk.org, Tal Shnaiderman , stable@dpdk.org, Bruce Richardson , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Tal Shnaiderman , William Tu Date: Tue, 14 Sep 2021 15:59:39 +0200 Message-ID: <2135018.IyJTUgjS8Y@thomas> In-Reply-To: References: <20210819231446.810897-1-dmitry.kozliuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] build: propagate Windows system dependencies to pkg-config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 20/08/2021 18:08, William Tu: > On Thu, Aug 19, 2021 at 4:15 PM Dmitry Kozlyuk wrote: > > > > Windows EAL depends on some system libraries. They were linked using > > add_project_link_arguments('-l'), which prevented meson from adding > > them to Libs.private of pkg-config file. As a result, applications using > > pkg-config to find DPDK hit link errors, for example: > > > > librte_eal.a(eal_windows_eal_debug.c.obj) : error LNK2019: unresolved > > external symbol __imp_SymInitialize referenced in function > > rte_dump_stack > > > > Reference required libraries in EAL using ext_deps meson variable. > > bus/pci and net/pcap depend on lib/eal and will pull them automatically. > > Drop advapi32 dependency, as MinGW locates VirtualAlloc2() dynamically. > > > > Fixes: 2a5d547a4a9b ("eal/windows: implement basic memory management") > > Fixes: c91717eb75c8 ("eal/windows: support exit and panic") > > Cc: talshn@nvidia.com > > Cc: stable@dpdk.org > > > > Reported-by: William Tu > > Signed-off-by: Dmitry Kozlyuk > > --- > > Thanks for the fix. > I've tested on my Windows environment and it works ok. > the libdpdk.pc shows the required libraries. > > Acked-by: William Tu Converted to Tested-by. Applied, thanks