From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 087BE424F0; Mon, 4 Sep 2023 15:22:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B0905402C1; Mon, 4 Sep 2023 15:22:29 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id CD2E8402BC; Mon, 4 Sep 2023 15:22:27 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 41BBE3200258; Mon, 4 Sep 2023 09:22:26 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 04 Sep 2023 09:22:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1693833745; x=1693920145; bh=IzcM/zg6pa/Uz/Sxcl63ImZ33o1NsSCPrhz J05+Clvs=; b=P+5HRVXo/1zQGSGRb4M0yV5/CsKtky2o+ZDhzqwfa5/dzs0lZfh l0NupQ4Yb22A08zfuP7uk4fN99xU3h4YtpWUJ/KM5g97hWNcAAkawRph+oNg1zLd ZPhXlvvnqbp+IW/2si7KoJ90St3YzG57eqhO+OhsERHXjcqrfF9O2ndfH3uS189C CYO4ydPW8lcEJcj86qNKVgEHOov9cvI2+e1Kh/wTIVk4hsqWqOIWe0o3qfHy2J02 brSf+831aGNwqtLGmtilpoCy6gHRgse7o/ZHGKShIHYvKcyIaz/tSpbkgEv5HSZN 4mnMaQ53CD9Sus9rRFd8dnNt+6M6he+5BKQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1693833745; x=1693920145; bh=IzcM/zg6pa/Uz/Sxcl63ImZ33o1NsSCPrhz J05+Clvs=; b=xE6+pj6EU16rIXgX2M9DN0qzLTxinFLIGnFKiLJE7qlHI0yNzLd PDqdm/+0K/bdxjgvnoEQ6ZSKqEj+FGzLYEk7HgF1E2uTxZ5ZpUzZR7+cbySkr3UE APHt0/rpK19TjNN1d8UiwoYu5bDZ5Vbdf348FiVr+P8sBIZIhF2Md/4z3/mKUbwu qtTqVfn/hp9bMk2Vn5q8YhLKvTYIV3Rn7cyxYt309m5AVkTJuo4luu3WfTON8mQC 6nxwI6OAktwQs1bHsqg0wQ3I3mdhiXCkCURNYBBbAiLXfNs+bC1DOfOTfKGIqmN/ aAvy0bboYtzq99xdN2mg8EPXmzntZ8yfgRQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudegkedgieehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 4 Sep 2023 09:22:23 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit , Bruce Richardson Cc: Konstantin Ananyev , Stephen Hemminger , "Varghese, Vipin" , "dev@dpdk.org" , "techboard@dpdk.org" , Morten =?ISO-8859-1?Q?Br=F8rup?= Subject: Re: [PATCH] usertools: suggest use of hwloc for new cpu Date: Mon, 04 Sep 2023 15:22:22 +0200 Message-ID: <2135020.3Lj2Plt8kZ@thomas> In-Reply-To: References: <20230812005720.997-1-vipin.varghese@amd.com> <40e74786-5854-37c2-7f52-1e5d43996b5d@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 04/09/2023 12:20, Bruce Richardson: > On Mon, Sep 04, 2023 at 11:11:20AM +0100, Ferruh Yigit wrote: > > On 8/14/2023 10:25 AM, Konstantin Ananyev wrote: > > > > > >> On Sun, Aug 13, 2023 at 08:52:01AM -0700, Stephen Hemminger wrote: > > >>> On Sun, 13 Aug 2023 02:12:03 +0000 > > >>> "Varghese, Vipin" wrote: > > >>> > > >>>>> > > >>>>> On Sat, 12 Aug 2023 06:27:20 +0530 > > >>>>> Vipin Varghese wrote: > > >>>>> > > >>>>>> Most modern processor now supports numa by partitioning NUMA based on > > >>>>>> CPU-IO & Last Level Cache within the same socket. > > >>>>>> As per the discussion in mailing list, suggesting the make use of > > >>>>>> hw-loc for such scenarios. > > >>>>>> > > >>>>>> Signed-off-by: Vipin Varghese > > >>>>> > > >>>>> NAK, no scripting hwloc, it is ugly and creates a dependency that is not listed > > >>>>> in DPDK packaging. > > >>>> > > >>>> There is no calls to hwloc within in thescript. Hence not clear what does ` NAK, no scripting hwloc it is ugly and creates a > > >> dependency that is not listed in DPDK packaging.`. > > >>>> > > >>>> Requesting to cross check why NAK is shared for `print` as suggestion. Hence, I have disagree to this. > > >>> > > >>> Sorry, I misinterpreted what the print's were doing. > > >>> Better off not to list exact flags, the lstopo may change and user may want different > > >>> format anyway. > > >>> > > >>> How about something like this? > > >>> > > >>> > > >>> doc/guides/rel_notes/deprecation.rst | 5 +++++ > > >>> usertools/cpu_layout.py | 5 +++++ > > >>> 2 files changed, 10 insertions(+) > > >>> > > >>> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > > >>> index 317875c5054b..25a116900dfb 100644 > > >>> --- a/doc/guides/rel_notes/deprecation.rst > > >>> +++ b/doc/guides/rel_notes/deprecation.rst > > >>> @@ -185,3 +185,8 @@ Deprecation Notices > > >>> will be deprecated and subsequently removed in DPDK 24.11 release. > > >>> Before this, the new port library API (functions rte_swx_port_*) > > >>> will gradually transition from experimental to stable status. > > >>> + > > >>> +* cpulayout: The CPU layout script is unable to deal with all the possible > > >>> + complexities of modern CPU topology. Other existing tools offer more > > >>> + features and do a better job with keeping up with innovations. > > >>> + Therefore it will be deprecated and removed in a future release. > > >> > > >> Does the script really do that bad a job? While I can understand us looking > > >> to recommend alternatives, I actually find the script in it's current form > > >> really handy - much more so than working out the exact flags for lstopo > > >> etc. Since it's not a large maintenance burden, I'd request we keep it > > >> around - while still recommending lstopo to users. > > > > > > +1 > > > I do use it on regular basis. > > > It would be a pity if it will be gone. > > > > > > > I also use it time to time and find it useful. > > > > But it is not accurate/correct for some AMD platforms (for various NPS > > (Nodes per Socket) values). > > So either it needs to be updated/improved or replaced. > > > > Vipin sent a patch [1] to update it but it is question how much of this > > logic belongs to DPDK, or should we rely on external tools dedicated for > > this purpose. > > > > I'd like to suggest that we take a slightly ambiguous position on this > script. Specifically: > > I think we should "recommend" but not "rely on" external tools for this. > Specifically, I think that recommending use of hwloc is the best thing to > do as it's better maintained and packaged for windows. However, for quick > use in many situations, cpu_layout does the job as well or better in terms > of simplicity of use and output. We could also contribute to hwloc to have a similar simple output.