* [PATCH] net: fix return type of IPv6 L4 packet checksum
@ 2023-04-06 9:21 eagostini
2023-04-06 9:35 ` Bing Zhao
2023-04-06 9:49 ` [PATCH v2] " eagostini
0 siblings, 2 replies; 6+ messages in thread
From: eagostini @ 2023-04-06 9:21 UTC (permalink / raw)
To: dev; +Cc: statble, Elena Agostini
From: Elena Agostini <eagostini@nvidia.com>
Function returns 0 or -1 but the return type is uint16_t.
Signed-off-by: Elena Agostini <eagostini@nvidia.com>
---
lib/net/rte_ip.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/net/rte_ip.h b/lib/net/rte_ip.h
index a310e9d498..e7106256aa 100644
--- a/lib/net/rte_ip.h
+++ b/lib/net/rte_ip.h
@@ -514,7 +514,7 @@ rte_ipv4_udptcp_cksum_verify(const struct rte_ipv4_hdr *ipv4_hdr,
* Return 0 if the checksum is correct, else -1.
*/
__rte_experimental
-static inline uint16_t
+static inline int
rte_ipv4_udptcp_cksum_mbuf_verify(const struct rte_mbuf *m,
const struct rte_ipv4_hdr *ipv4_hdr,
uint16_t l4_off)
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] net: fix return type of IPv6 L4 packet checksum
2023-04-06 9:21 [PATCH] net: fix return type of IPv6 L4 packet checksum eagostini
@ 2023-04-06 9:35 ` Bing Zhao
2023-04-06 9:49 ` [PATCH v2] " eagostini
1 sibling, 0 replies; 6+ messages in thread
From: Bing Zhao @ 2023-04-06 9:35 UTC (permalink / raw)
To: Elena Agostini, dev, Olivier Matz,
NBU-Contact-Thomas Monjalon (EXTERNAL)
Cc: statble
Hi Elena,
Maybe it is better to add a fixline here.
BR. Bing
> -----Original Message-----
> From: eagostini@nvidia.com <eagostini@nvidia.com>
> Sent: Thursday, April 6, 2023 5:21 PM
> To: dev@dpdk.org
> Cc: statble@dpdk.org; Elena Agostini <eagostini@nvidia.com>
> Subject: [PATCH] net: fix return type of IPv6 L4 packet checksum
>
> External email: Use caution opening links or attachments
>
>
> From: Elena Agostini <eagostini@nvidia.com>
>
> Function returns 0 or -1 but the return type is uint16_t.
>
> Signed-off-by: Elena Agostini <eagostini@nvidia.com>
> ---
> lib/net/rte_ip.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/net/rte_ip.h b/lib/net/rte_ip.h index a310e9d498..e7106256aa
> 100644
> --- a/lib/net/rte_ip.h
> +++ b/lib/net/rte_ip.h
> @@ -514,7 +514,7 @@ rte_ipv4_udptcp_cksum_verify(const struct
> rte_ipv4_hdr *ipv4_hdr,
> * Return 0 if the checksum is correct, else -1.
> */
> __rte_experimental
> -static inline uint16_t
> +static inline int
> rte_ipv4_udptcp_cksum_mbuf_verify(const struct rte_mbuf *m,
> const struct rte_ipv4_hdr *ipv4_hdr,
> uint16_t l4_off)
> --
> 2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] net: fix return type of IPv6 L4 packet checksum
2023-04-06 9:21 [PATCH] net: fix return type of IPv6 L4 packet checksum eagostini
2023-04-06 9:35 ` Bing Zhao
@ 2023-04-06 9:49 ` eagostini
2023-04-12 8:22 ` Thomas Monjalon
2023-04-12 8:24 ` [PATCH v3] net: fix return type of IPv4 " eagostini
1 sibling, 2 replies; 6+ messages in thread
From: eagostini @ 2023-04-06 9:49 UTC (permalink / raw)
To: dev; +Cc: stable, thomas, Elena Agostini, xiaoyun.li
From: Elena Agostini <eagostini@nvidia.com>
Function returns 0 or -1 but the return type is uint16_t.
Fixes: d178f693bbfe ("net: add UDP/TCP checksum in mbuf segments")
Cc: xiaoyun.li@intel.com
Signed-off-by: Elena Agostini <eagostini@nvidia.com>
---
V2:
added fixline and fixed cc address
---
---
lib/net/rte_ip.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/net/rte_ip.h b/lib/net/rte_ip.h
index a310e9d498..e7106256aa 100644
--- a/lib/net/rte_ip.h
+++ b/lib/net/rte_ip.h
@@ -514,7 +514,7 @@ rte_ipv4_udptcp_cksum_verify(const struct rte_ipv4_hdr *ipv4_hdr,
* Return 0 if the checksum is correct, else -1.
*/
__rte_experimental
-static inline uint16_t
+static inline int
rte_ipv4_udptcp_cksum_mbuf_verify(const struct rte_mbuf *m,
const struct rte_ipv4_hdr *ipv4_hdr,
uint16_t l4_off)
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] net: fix return type of IPv6 L4 packet checksum
2023-04-06 9:49 ` [PATCH v2] " eagostini
@ 2023-04-12 8:22 ` Thomas Monjalon
2023-04-12 8:26 ` Thomas Monjalon
2023-04-12 8:24 ` [PATCH v3] net: fix return type of IPv4 " eagostini
1 sibling, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2023-04-12 8:22 UTC (permalink / raw)
To: Elena Agostini; +Cc: dev, stable, xiaoyun.li
06/04/2023 11:49, eagostini@nvidia.com:
> From: Elena Agostini <eagostini@nvidia.com>
>
> Function returns 0 or -1 but the return type is uint16_t.
>
> Fixes: d178f693bbfe ("net: add UDP/TCP checksum in mbuf segments")
> Cc: xiaoyun.li@intel.com
>
> Signed-off-by: Elena Agostini <eagostini@nvidia.com>
The title should be about IPv4, not IPv6.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v3] net: fix return type of IPv4 L4 packet checksum
2023-04-06 9:49 ` [PATCH v2] " eagostini
2023-04-12 8:22 ` Thomas Monjalon
@ 2023-04-12 8:24 ` eagostini
1 sibling, 0 replies; 6+ messages in thread
From: eagostini @ 2023-04-12 8:24 UTC (permalink / raw)
To: dev; +Cc: stable, thomas, Elena Agostini, xiaoyun.li
From: Elena Agostini <eagostini@nvidia.com>
Function returns 0 or -1 but the return type is uint16_t.
Fixes: d178f693bbfe ("net: add UDP/TCP checksum in mbuf segments")
Cc: xiaoyun.li@intel.com
Signed-off-by: Elena Agostini <eagostini@nvidia.com>
---
V2:
added fixline and fixed cc address
V3:
title changed
---
lib/net/rte_ip.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/net/rte_ip.h b/lib/net/rte_ip.h
index a310e9d498..e7106256aa 100644
--- a/lib/net/rte_ip.h
+++ b/lib/net/rte_ip.h
@@ -514,7 +514,7 @@ rte_ipv4_udptcp_cksum_verify(const struct rte_ipv4_hdr *ipv4_hdr,
* Return 0 if the checksum is correct, else -1.
*/
__rte_experimental
-static inline uint16_t
+static inline int
rte_ipv4_udptcp_cksum_mbuf_verify(const struct rte_mbuf *m,
const struct rte_ipv4_hdr *ipv4_hdr,
uint16_t l4_off)
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] net: fix return type of IPv6 L4 packet checksum
2023-04-12 8:22 ` Thomas Monjalon
@ 2023-04-12 8:26 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2023-04-12 8:26 UTC (permalink / raw)
To: Elena Agostini; +Cc: stable, dev, stable, xiaoyun.li
12/04/2023 10:22, Thomas Monjalon:
> 06/04/2023 11:49, eagostini@nvidia.com:
> > From: Elena Agostini <eagostini@nvidia.com>
> >
> > Function returns 0 or -1 but the return type is uint16_t.
> >
> > Fixes: d178f693bbfe ("net: add UDP/TCP checksum in mbuf segments")
> > Cc: xiaoyun.li@intel.com
> >
> > Signed-off-by: Elena Agostini <eagostini@nvidia.com>
>
> The title should be about IPv4, not IPv6.
Applied with this fix and adding Cc: stable@dpdk.org
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-04-12 8:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-06 9:21 [PATCH] net: fix return type of IPv6 L4 packet checksum eagostini
2023-04-06 9:35 ` Bing Zhao
2023-04-06 9:49 ` [PATCH v2] " eagostini
2023-04-12 8:22 ` Thomas Monjalon
2023-04-12 8:26 ` Thomas Monjalon
2023-04-12 8:24 ` [PATCH v3] net: fix return type of IPv4 " eagostini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).