DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH dpdk] buildtools/cmdline: fix meson error when used as a subproject
@ 2024-08-01 10:01 Robin Jarry
  2024-08-07 13:43 ` Bruce Richardson
  0 siblings, 1 reply; 3+ messages in thread
From: Robin Jarry @ 2024-08-01 10:01 UTC (permalink / raw)
  To: dev, Bruce Richardson; +Cc: stable

Fix the following error when using dpdk as a subproject:

 subprojects/dpdk/buildtools/subproject/meson.build:28:56:
 ERROR: Unknown function "file".

This was obviously never tested in its submitted form.

Cc: stable@dpdk.org
Fixes: 7d8c608faa7f ("buildtools/cmdline: allow using script in subproject")

Signed-off-by: Robin Jarry <rjarry@redhat.com>
---
 buildtools/subproject/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/buildtools/subproject/meson.build b/buildtools/subproject/meson.build
index 9ba94671bd0e..8ae081e1698a 100644
--- a/buildtools/subproject/meson.build
+++ b/buildtools/subproject/meson.build
@@ -25,4 +25,4 @@ endif
 
 libdpdk_dep = dpdk_dep
 
-meson.override_find_program('dpdk-cmdline-gen.py', file('../dpdk-cmdline-gen.py'))
+meson.override_find_program('dpdk-cmdline-gen.py', files('../dpdk-cmdline-gen.py'))
-- 
2.45.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH dpdk] buildtools/cmdline: fix meson error when used as a subproject
  2024-08-01 10:01 [PATCH dpdk] buildtools/cmdline: fix meson error when used as a subproject Robin Jarry
@ 2024-08-07 13:43 ` Bruce Richardson
  2024-10-11 14:43   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2024-08-07 13:43 UTC (permalink / raw)
  To: Robin Jarry; +Cc: dev, stable

On Thu, Aug 01, 2024 at 12:01:54PM +0200, Robin Jarry wrote:
> Fix the following error when using dpdk as a subproject:
> 
>  subprojects/dpdk/buildtools/subproject/meson.build:28:56:
>  ERROR: Unknown function "file".
> 
> This was obviously never tested in its submitted form.
> 
> Cc: stable@dpdk.org
> Fixes: 7d8c608faa7f ("buildtools/cmdline: allow using script in subproject")
> 
> Signed-off-by: Robin Jarry <rjarry@redhat.com>
> ---

Good catch, and easy fix, thanks.

Interestingly, even without testing the build, vscode meson extension
flags this issue in the "problems" tab of vscode: "Unknown function `file`"

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH dpdk] buildtools/cmdline: fix meson error when used as a subproject
  2024-08-07 13:43 ` Bruce Richardson
@ 2024-10-11 14:43   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2024-10-11 14:43 UTC (permalink / raw)
  To: Robin Jarry; +Cc: dev, stable, Bruce Richardson

07/08/2024 15:43, Bruce Richardson:
> On Thu, Aug 01, 2024 at 12:01:54PM +0200, Robin Jarry wrote:
> > Fix the following error when using dpdk as a subproject:
> > 
> >  subprojects/dpdk/buildtools/subproject/meson.build:28:56:
> >  ERROR: Unknown function "file".
> > 
> > This was obviously never tested in its submitted form.
> > 
> > Cc: stable@dpdk.org
> > Fixes: 7d8c608faa7f ("buildtools/cmdline: allow using script in subproject")
> > 
> > Signed-off-by: Robin Jarry <rjarry@redhat.com>
> > ---
> 
> Good catch, and easy fix, thanks.
> 
> Interestingly, even without testing the build, vscode meson extension
> flags this issue in the "problems" tab of vscode: "Unknown function `file`"
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks.



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-10-11 14:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-01 10:01 [PATCH dpdk] buildtools/cmdline: fix meson error when used as a subproject Robin Jarry
2024-08-07 13:43 ` Bruce Richardson
2024-10-11 14:43   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).