DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v11 0/4] Hyper-V/Azure netvsc PMD and bus support
Date: Thu, 12 Jul 2018 21:55:04 +0200	[thread overview]
Message-ID: <2142629.lVosk762JX@xps> (raw)
In-Reply-To: <20180612232939.24793-1-stephen@networkplumber.org>

The old offload API has been removed.
Please could you adapt this PMD to the new API?

The errors are:
../drivers/net/netvsc/hn_ethdev.c:185:4: error: ‘struct rte_eth_txconf’ has no member named ‘txq_flags’
../drivers/net/netvsc/hn_ethdev.c:185:16: error: ‘ETH_TXQ_FLAGS_NOXSUMS’ undeclared (first use in this function)
   .txq_flags = ETH_TXQ_FLAGS_NOXSUMS,


Some checkpatches warnings are remaining:

### [dpdk-dev] [PATCH v11 2/4] bus/vmbus: add hyper-v virtual bus support

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#353: FILE: drivers/bus/vmbus/linux/vmbus_bus.c:28:
+extern struct rte_vmbus_bus rte_vmbus_bus;

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#2715: FILE: drivers/bus/vmbus/vmbus_common.c:26:
+extern struct rte_vmbus_bus rte_vmbus_bus;

### [dpdk-dev] [PATCH v11 3/4] net/netvsc: add hyper-v netvsc network device

CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#519: FILE: drivers/net/netvsc/hn_ethdev.c:189:
+       dev_info->flow_type_rss_offloads
+               = ETH_RSS_IPV4 | ETH_RSS_IPV6 | ETH_RSS_TCP | ETH_RSS_UDP;

CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#622: FILE: drivers/net/netvsc/hn_ethdev.c:292:
+       const struct rte_eth_rss_conf *rss_conf
+               = &dev_conf->rx_adv_conf.rss_conf;

CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#632: FILE: drivers/net/netvsc/hn_ethdev.c:302:
+                           "unsupported TX offload: %#" PRIx64,

CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#788: FILE: drivers/net/netvsc/hn_ethdev.c:458:
+       const unsigned int nstats
+               = dev->data->nb_tx_queues * RTE_DIM(hn_stat_strings)

CHECK:CAMELCASE: Avoid CamelCase: <PRIx32>
#2644: FILE: drivers/net/netvsc/hn_rndis.c:720:
+               PMD_DRV_LOG(ERR, "exec RNDIS set %#" PRIx32 " failed",

CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=' should be on the previous line
#3500: FILE: drivers/net/netvsc/hn_rxtx.c:441:
+               struct rte_eth_dev *dev
+                       = &rte_eth_devices[rxq->port_id];

      parent reply	other threads:[~2018-07-12 19:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-12 23:29 Stephen Hemminger
2018-06-12 23:29 ` [dpdk-dev] [PATCH v11 1/4] eal: add rte_uuid support Stephen Hemminger
2018-06-12 23:29 ` [dpdk-dev] [PATCH v11 2/4] bus/vmbus: add hyper-v virtual bus support Stephen Hemminger
2018-06-12 23:29 ` [dpdk-dev] [PATCH v11 3/4] net/netvsc: add hyper-v netvsc network device Stephen Hemminger
2018-06-12 23:29 ` [dpdk-dev] [PATCH v11 4/4] net/netvsc: add documentation Stephen Hemminger
2018-07-12 19:55 ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2142629.lVosk762JX@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).