From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com
 [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id DF8B38E97
 for <dev@dpdk.org>; Tue, 20 Oct 2015 09:08:58 +0200 (CEST)
Received: by wicfv8 with SMTP id fv8so13881241wic.0
 for <dev@dpdk.org>; Tue, 20 Oct 2015 00:08:58 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=dW2v+zq+2hOcGw+8XvjG4YqOpoUl75jvYhhL4JaSn6E=;
 b=Z5Opaf4MwQW/zJg+eqFE/dCjodBqXRh/i/sk08wtL8QRBVmLJ4oXTep7TDUCT8YhWe
 6NNq995vom3p/UF3MWxu4NX7ya4Yy4dIOJ3997MfI+AUF1v8j5ExHWQinVtEfGNRjwUq
 KFfZltEEc+mZoVu9298QKxbG1xYOtbkHLtVH/i/cajiS2sR14LR/pSufj9j1OpVsG6SV
 ntBHRc8lAuIXwwYjbWVAnRKTbjdT5ehd2ip7QZs5iEPcMm3J4b6fMFDBLU4hDJ63sgQB
 AcYlOLXPqBnjKowV+97vPhYbSc37+YAqYEjoiI2jxY7UnCLI4B9Y4c4Mc2mvjIuMq66X
 Wy1w==
X-Gm-Message-State: ALoCoQkVdY91Q2alLrfPym7Lt+Eyee9F8SiQejCFJoHPAOhh6b+OKpsk1hJ1puvQ1N9bJtweARvW
X-Received: by 10.194.79.196 with SMTP id l4mr2146732wjx.93.1445324938654;
 Tue, 20 Oct 2015 00:08:58 -0700 (PDT)
Received: from xps13.localnet (115.202.154.77.rev.sfr.net. [77.154.202.115])
 by smtp.gmail.com with ESMTPSA id z2sm1664556wij.1.2015.10.20.00.08.57
 (version=TLSv1/SSLv3 cipher=OTHER);
 Tue, 20 Oct 2015 00:08:58 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Date: Tue, 20 Oct 2015 09:07:49 +0200
Message-ID: <2143283.gKIdjTGCRD@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <1444369572-1157-7-git-send-email-yuanhan.liu@linux.intel.com>
References: <1444369572-1157-1-git-send-email-yuanhan.liu@linux.intel.com>
 <1444369572-1157-7-git-send-email-yuanhan.liu@linux.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org, marcel@redhat.com, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v6 06/13] virtio: read virtio_net_config
	correctly
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Oct 2015 07:08:59 -0000

2015-10-09 13:46, Yuanhan Liu:
> From: Changchun Ouyang <changchun.ouyang@intel.com>
> 
> The old code adjusts the config bytes we want to read depending on
> what kind of features we have, but we later cast the entire buf we
> read with "struct virtio_net_config", which is obviously wrong.

When describing a bug, it is important to explain what is the consequence,
i.e. which use case is failing. If it is only to prepare the new feature,
it is better to clearly state that the bug had no impact until now.

And as usual, the "fix" word in the title and the "Fixes" tag are required.