From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 80C92A04E0; Wed, 27 Nov 2019 10:42:58 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5A0A75596; Wed, 27 Nov 2019 10:42:58 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id B4E3828EE for ; Wed, 27 Nov 2019 10:42:56 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C9DC12235B; Wed, 27 Nov 2019 04:42:55 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 27 Nov 2019 04:42:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=583Lm5JY5CmHWYkPBamJCNPQj96fFfh3U2/IMSVjVR8=; b=gyL6Vj6W+Kir 8WhQV0RNSX2AVuqk9cgq5fpjXNprrnZg52bmcIEHfeE3Pkd2BSl59JN+6ZYDHlom 0U9YRGzoxml0ehBU3XIm+VCt8UZobdjIB/rAGsR86VR8pSd/Dq7dszCUD5A8vpbS 9IBhAy7Jsu4uPVuBtT8EYXxcNSe3UX8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=583Lm5JY5CmHWYkPBamJCNPQj96fFfh3U2/IMSVjV R8=; b=ECR8J7ni5hUfWbGuE1h2wjFQO8mS/Qv/rtqPiHJuIty9ZpjPn6wV8VbaR 2ai7PGPfbbMBVpEPzImXnGjvarhLwc7Ze60gVFgH55AE3R+iRQP7BUfD2yvkRgM2 SqKiFbtoR4FGAdoKShz8gaA/C05hz5Yz+b91Sv2K/O3qtSHxMIVxxgLtq6hCIXP5 pxUfw0xdvjX2834gGLda9xdZkWwU8dafEGYZLM4bKeE0zJGdSOFwU48HDdQYAe6s b7fzriEV1RnxQfIyv97Nf8TXGxpdk6HvT4UfHoZTu7VzxGYQiTBQ2KNB2ZobzhjP ahEGc7e6sEVET/CWW3iGvf/Qpocnw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudeihedgtdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrddvtdefrddukeegnecu rfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtne cuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 80DD93060065; Wed, 27 Nov 2019 04:42:54 -0500 (EST) From: Thomas Monjalon To: Sunil Kumar Kori Cc: "dev@dpdk.org" , Jerin Jacob Kollanukkaran , Nithin Kumar Dabilpuram , Vamsi Krishna Attunuru , Kiran Kumar Kokkilagadda , Satha Koteswara Rao Kottidi Date: Wed, 27 Nov 2019 10:42:53 +0100 Message-ID: <2143441.VyhVeLpU10@xps> In-Reply-To: References: <20191125113537.25266-1-skori@marvell.com> <12400674.vvbXqBG5NK@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/5] drivers/octeontx2: allow experimental symbols X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 27/11/2019 09:34, Sunil Kumar Kori: > From: Thomas Monjalon > >26/11/2019 07:15, Sunil Kumar Kori: > >> Multiple experimental symbols are used. They must be allowed to avoid > >> compilation error. > > > >If there was an error, > >1/ I would see it in my compilation test 2/ There would be some "Fixes:" tag to > >point the root cause > > Actually change is part of below series which is started using experimental symbols in mentioned driver. > Apart of these drivers, FLAGs are already present in other drivers so that there is no error found. > Error occurs when applying below series. > > So I had two options to get it done. Either I can do Makefile changes along with the corresponding changes or > make them as a separate patch. I have chosen second option. This is the wrong choice :) When you do a change, it should be atomic, i.e. includes changes which are dependent. > And because of this is new change, it does not contain any "Fixes" tag. > > > >I guess this patch is not critical. > >Where are patches 2, 3, 4, 5? > Following are the series of patches: > http://patches.dpdk.org/patch/63299/ > http://patches.dpdk.org/patch/63271/ > http://patches.dpdk.org/patch/63272/ > http://patches.dpdk.org/patch/63273/ > http://patches.dpdk.org/patch/63274/ > Not all the patches are reworked for next versions that's why same is not reflected in subject line. When you send a new version, you should send the whole series again. And please don't forget changelogs and --in-reply-to. Thanks