From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id BA0641B169 for ; Wed, 10 Jan 2018 11:53:13 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 43A8120B0B; Wed, 10 Jan 2018 05:53:13 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Wed, 10 Jan 2018 05:53:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=Jbxd29vgR7lJ9HKdVxgLzEP48U v7CQKv0/my8F3mgV4=; b=JzkPrMlfQntAZkPe4CtOlz0voroE0gNrMZ/2buqYz3 x8KLDz3wh5g+n1Wg9Ny4xIdKBlGVqXJzHd5QvG0FVm0z4Z0LHficp7tpShgpx5K2 OZpS0/w++jBFLGOM3mN/+m+IvxwPatMHLn5EuOkbg6ZCwB4H0GyE3AdP+gUm193d A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Jbxd29 vgR7lJ9HKdVxgLzEP48Uv7CQKv0/my8F3mgV4=; b=UW5YVTa+k4DddzS5kb2P/c dAhTeiJIrpNSRjCdamw2Hse5FQK+9UF7hDdmcwWT3wWNoLmAhn/ZhUGj2r13IGqi CR381XDJidrW1du8KpBAC0JzjV7I+Ma7jb4PT8y8n0YV8sr067qiZLrtbiiBNe/B oMafxq65M4IIOsKCapat60IX0MejoIw4gV3SsNwMczHgXBfJw1AQzT9HaXoaVeVH bW+XlH4G9fYT4h5r7Un3mG4z7L0A1Q9QAbqkR6H8YwgxP4FeJxpa9UEFVXWwcuvN vCd1tQL7vAOjKjtR5lspl3Sau/hKPqAo6iQPNSIhkV0oVcn8g14MN5Xi5e/qPfvQ == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E991C24235; Wed, 10 Jan 2018 05:53:12 -0500 (EST) From: Thomas Monjalon To: "Singh, Jasvinder" Cc: dev@dpdk.org, "Iremonger, Bernard" , "Kovacevic, Marko" Date: Wed, 10 Jan 2018 11:52:46 +0100 Message-ID: <2144605.X1J6VfJWv8@xps> In-Reply-To: <54CBAA185211B4429112C315DA58FF6D332C3E4B@IRSMSX103.ger.corp.intel.com> References: <20171215103924.5185-1-jasvinder.singh@intel.com> <2932732.5Kg9JDsi0f@xps> <54CBAA185211B4429112C315DA58FF6D332C3E4B@IRSMSX103.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 1/4] lib/librte_flow_classify: remove table id parameter from apis X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jan 2018 10:53:13 -0000 10/01/2018 10:54, Singh, Jasvinder: > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > 19/12/2017 15:29, Jasvinder Singh: > > > This patch removes table id parameter from all the flow classify apis > > > to reduce the complexity alongwith some code cleanup. > > > > > > The validate api is exposed as public api to allow user to validate > > > the flow before adding it to the classifier. > > > > This patch does not compile alone. > > Should we merge all patches together? > > No, It should compile alone. On my system it doesn't show any error and compilation goes successfully. Could you send me error log, etc ? test/test/test_flow_classify.c:48:10: fatal error: too many arguments to function call, expected 6, have 7 NULL, NULL); ^~~~ I guess it is expected that test and example does not compile after patch 1. That's why I suggest to merge all 4 patches.