From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com
 [209.85.212.174]) by dpdk.org (Postfix) with ESMTP id 7C851C4FA
 for <dev@dpdk.org>; Wed, 29 Jul 2015 10:44:08 +0200 (CEST)
Received: by wibud3 with SMTP id ud3so15707478wib.0
 for <dev@dpdk.org>; Wed, 29 Jul 2015 01:44:08 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=nJW03zO/EsF+v3/NjC6zwMGoEtMy5deHlJ3ZzWSM510=;
 b=B+vjCClsMCvc0Epkh+M27HnepYqyCLAnq0XQwB558X9EM7OZubSIUfwMdBWHf4UkcY
 biiu9hBeicaSQW2HYu/VMU7q6peeOBqeaRHYh4+nxNZ58uumTeANv02IPC09e5aZYKGh
 UDAHlRlUc1Fk07+QQm2Iil9gV4jwxcCpM/aKnhcOAaUi0Kfgto880rgs9i5su2XYbKKk
 NFOwpDucWNJwyguD0Wgks1lP/J0Cvk9ZHTgYgsDKpCNSUG67ZLNoP9QQnwi3okEpfs22
 YMmttmL3dORfPQQvtnxq2Ums6mN1I9sTOTSRRoIGkTGObWJNISUjRmndm433AXYUFc5C
 GW9w==
X-Gm-Message-State: ALoCoQn+PlviceHB1vgy4+5kqWjY0iMKkpPMXRN9EMzC7GR27jkRV1dqlsykZRaVG+7vI//X9L8J
X-Received: by 10.194.87.102 with SMTP id w6mr72093608wjz.111.1438159448309;
 Wed, 29 Jul 2015 01:44:08 -0700 (PDT)
Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.151.210])
 by smtp.gmail.com with ESMTPSA id lu5sm37342279wjb.9.2015.07.29.01.44.06
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 29 Jul 2015 01:44:07 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Michael Qiu <michael.qiu@intel.com>
Date: Wed, 29 Jul 2015 10:42:51 +0200
Message-ID: <2144726.adBAHMgyBQ@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <1438131904-23221-1-git-send-email-michael.qiu@intel.com>
References: <1438131904-23221-1-git-send-email-michael.qiu@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] test-pmd: show pci address in port info
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Jul 2015 08:44:08 -0000

2015-07-29 09:05, Michael Qiu:
> pci address is one important info for port.
> This patch make it visible for port info.
> 
> Signed-off-by: Michael Qiu <michael.qiu@intel.com>

Maybe you missed this thread:
	http://dpdk.org/ml/archives/dev/2015-July/022107.html

> +	if (strncmp("0000:00:00.0", pci_addr, 12))
> +		printf("\nPCI address: %s", pci_addr);
> +	else
> +		printf("\nPCI address: N/A");

Checking a null PCI address to handle non-pci devices is ugly.
EAL must be reworked to correctly handle non-PCI devices.
Patches welcome.

This patch is rejected.