From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id F2CE9239 for ; Wed, 7 Nov 2018 22:10:18 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9B89922056; Wed, 7 Nov 2018 16:10:18 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 07 Nov 2018 16:10:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=EfmeTNHZ5Njt3tUFEqNWeB87eTHE7znyZgDE2QZprwY=; b=qr/67PaA/eOG D+5Bb1xt582/kB+BibSvSF1lc5OywARio58ggM2/KTszn2e6gxzHjJcm0ZkODJje gjepdDTpGhk2trPdXCcjJ/PZ1qEjremAwygH5YxrtaobHG/8yjeRm/woxi18SKcp q5aFRS/ijClu3AwSvYkXXy3YPdcWwvI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=EfmeTNHZ5Njt3tUFEqNWeB87eTHE7znyZgDE2QZpr wY=; b=mH/ogVeoZgWVfwQwIsKupIxNoCRuki8D2FiICuy0vWLHsa6uRQyHloxhu xmFKIr9odA3yCjdg55SFeP7xHdQfCXRiyR09WBl9xJRB5sw8gS/0cG2By57tIFj5 LpAPUZmeKxtqi07UU2acsWstK8b0nSY51RA2ayGxjJmKI68Sh3NtlmIqgzeKiU6J 7Y4ICdFZD2bc3nuSKcaKfOfM5VmAMbskZVQTc0YvEe+5SGIAjm1z2NTnhr4u8ocv wrXlN80UmHPtfkOeteZvd5hCawtgUn8K2TlYdJfC8uEwk6wJEBIxiNxdcLMHIArW vCxvvgxEChM1/kaJi/15qaT6YTPYg== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 82BA0E4430; Wed, 7 Nov 2018 16:10:16 -0500 (EST) From: Thomas Monjalon To: dwilder Cc: dev@dpdk.org, christian.ehrhardt@canonical.com, adrien.mazarguil@6wind.com, shahafs@mellanox.com, yskoh@mellanox.com, gowrishankar.m@linux.vnet.ibm.com, chaozhu@linux.vnet.ibm.com, pradeep@us.ibm.com, tyos@jp.ibm.com Date: Wed, 07 Nov 2018 22:10:14 +0100 Message-ID: <2145434.ZaoFnF2QHS@xps> In-Reply-To: <30471765b219a14d31a795ea4d77eedb@linux.vnet.ibm.com> References: <20180903092911.GU3695@6wind.com> <20181107160028.5938-1-thomas@monjalon.net> <30471765b219a14d31a795ea4d77eedb@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix build on PPC64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Nov 2018 21:10:19 -0000 07/11/2018 20:05, dwilder: > On 2018-11-07 08:00, Thomas Monjalon wrote: > > The AltiVec header file breaks boolean type: > > > > error: incompatible types when initializing type > > '__vector _bool int' {aka '_vector(4) __bool int'} using type 'int' > > > > If __APPLE_ALTIVEC__ is defined, then bool type is redefined > > and conflicts with stdbool.h. > > > > There is no good solution to fix it for the whole project without > > breaking something else, so a workaround is inserted in mlx5 PMD. > > This workaround is not compatible with C++ but there is no C++ in DPDK. > > > > Suggested-by: Christian Ehrhardt > > Suggested-by: Adrien Mazarguil > > Signed-off-by: Thomas Monjalon > > > > Tested-by: David Wilder > > Hi Thomas > > Thanks for re-posting this patch. I see no build breaks on power8 or > power9 with this patch. I tried both 18.11-rc1 and upstream (master). It is not really a re-post. I took the last solution which was proposed for EAL, and applied it to mlx5 only.