From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C38EC42CFA; Mon, 19 Jun 2023 15:25:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 50AC740E0F; Mon, 19 Jun 2023 15:25:21 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id E0C3E40DF8 for ; Mon, 19 Jun 2023 15:25:19 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 304E63200954; Mon, 19 Jun 2023 09:25:18 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 19 Jun 2023 09:25:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1687181117; x=1687267517; bh=yvfz3kwEfH9IPs5m3b6VZVY63NhUDlQKaOp +ec2nHu4=; b=PRO6zJ8sdEx3LoRZItc5dT4LaLK+XsqxvL9w+eY9MUe4y4x4aah 24yKatLw2YSkGuHxlp9+2OGSJXj2kKbGISy+Dr8VS2A7bNjq0OQHDWIaj4yKRcdA rOwqt5PvoceJwSv9gjgtGn1pkDbuGNLSvs6ylAtF2Jt/+6Mx0Sjoe7ROaQZIanT6 x+TtwGzRZwEnUjeFda+eB+IaJy3omx7JbM4IbxhAHBhQEsxr8oitINXj9HebDYi6 j4RQcZeiU4DQd6SNwhNGz5qEBPGSrqu9K/v0nVWvEYoXiLwYgGn4F19z7A+6ScRr jdkrNWmSGDOrICE/n9PqL5zVjMT6yl0FxZw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1687181117; x=1687267517; bh=yvfz3kwEfH9IPs5m3b6VZVY63NhUDlQKaOp +ec2nHu4=; b=AE3b6nhxVok29KXoi4KeaU2ygU0Cap1MZDJrVx9Xe+J1jHr3G1o DlXdn5vlOycgVSBO4IrtR0gUVproJxg423tKntjPaUNgEn3cQOKsnDswgZWwFWLz 14c24Y/7aIiP2WEekI62S2yEVLVYJK/MQ9INQC2eoKY08TSL4dn2F3GPBrdl7vCb vPPJhpzzF/ZAe74oBDNaBs09HKbUxGx2swDbk3HyDyrZmC3ii74l3tDmjJ2gmv0a b7s6k2mIjw1tOo+Us9+YlxgXfYbrSmwuRuq/L0ZehjxNNn/tWtSCZ2c4n1lpvphc ezulrK1JpjBTMhAHckBufltl05LHtKl9AVg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeefvddgieefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 19 Jun 2023 09:25:16 -0400 (EDT) From: Thomas Monjalon To: jiayu.hu@intel.com Cc: dev@dpdk.org, Kumara Parameshwaran , Kumara Parameshwaran , Kumara Parameshwaran Subject: Re: [PATCH v5] gro : fix reordering of packets in GRO library Date: Mon, 19 Jun 2023 15:25:15 +0200 Message-ID: <2145514.irdbgypaU6@thomas> In-Reply-To: <20221101070557.58808-1-kumaraparmesh92@gmail.com> References: <20221028095114.17210-1-kumaraparmesh92@gmail.com> <20221101070557.58808-1-kumaraparmesh92@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 01/11/2022 08:05, Kumara Parameshwaran: > From: Kumara Parameshwaran > > When a TCP packet contains flags like PSH it is returned > immediately to the application though there might be packets of > the same flow in the GRO table. If PSH flag is set on a segment > packets up to the segment should be delivered immediately. But the > current implementation delivers the last arrived packet with PSH flag > set causing re-ordering > > With this patch, if a packet does not contain only ACK flag and if > there are no previous packets for the flow the packet would be returned > immediately, else will be merged with the previous segment and the > flag on the last segment will be set on the entire segment. > This is the behaviour with linux stack as well. > > Signed-off-by: Kumara Parameshwaran > Co-authored-by: Kumara Parameshwaran This is yourself, right? Please choose one email address and use it in your git config. Jiayu, any comment about the patch content?