From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 27E972A5E for ; Fri, 18 Mar 2016 12:45:57 +0100 (CET) Received: by mail-wm0-f50.google.com with SMTP id p65so33316352wmp.0 for ; Fri, 18 Mar 2016 04:45:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=k8/YldwvCKGIVWZ/nd0qHQGG4OQqya6P5K3oHjMp88U=; b=KNy0IWsRUMidQvM/XX0KL00KUK0+zJmr28R0i1i8cuPvDuvfH2uA0IUDATym+8mzt6 2YehI5sK2c8/04hO8ou5ndJ4aVo9FyCxYp7HAYLttNFpsZlkDtG73SX8xCet7WKviDRB CjCmkloot5FM11ASQCk+XGZpJdu2AAWy5loI6yXoo/qjgCrwsT4BxDF9h2uCykq8PUYp AFWEaOSnR4scrH755+v8N68tvnKAkhhW4LsI3BikqzzR6iziO/96CFqHx/FUrcdk8JQW 4fc1Aw/fK8/Q5Q46laqq7kWmGCP6umNYTvSYOIaMzgOPZd1utyVOdcwXFJhU/GCMXvyV RKHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=k8/YldwvCKGIVWZ/nd0qHQGG4OQqya6P5K3oHjMp88U=; b=YOW1bhPqyGOoyvf8hDsabQOuSw9jO6Di5QB0uk32dYgOfsW9Uhupv2LbKY5BtwKXjB 8f0riht8CenLp9lWC4sUmr0pS+3AtYLscn9X0d908v5Q2BnW094aBafYPrjQsd/Ghla+ PYgQzQlhGCFKCfQ1giwas7kP4OKik4PI2eJnkrI7SOTz2cKM7vdQGjA/b3dNXjNVq5uJ A+mHDXAg/T6CxAf3+nzXXgYSO0fqButBLrn8DKhRXXR93yEwokppLCW3Rw3SiK3uDTX4 W4WVHJD7WsmBIpkE60LTTglnP+6/5LVOwZUBZSc5wDW1dmCEIqo2b/rkC8Nc3Bmy4AKG 5ITA== X-Gm-Message-State: AD7BkJI/k8NNKoi63IPynZw5/LmjaeqsetAD6n4iB8+EhTwzc1avUrn0kwF8Z+G0yMrcHvc/ X-Received: by 10.28.30.215 with SMTP id e206mr39340268wme.25.1458301556956; Fri, 18 Mar 2016 04:45:56 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id da6sm11917742wjb.24.2016.03.18.04.45.54 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 18 Mar 2016 04:45:55 -0700 (PDT) From: Thomas Monjalon To: Jingjing Wu Cc: dev@dpdk.org, bruce.richardson@intel.com Date: Fri, 18 Mar 2016 12:44:23 +0100 Message-ID: <21476039.orzeTHEBVW@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1457580346-18550-8-git-send-email-jingjing.wu@intel.com> References: <1457502180-14124-1-git-send-email-jingjing.wu@intel.com> <1457580346-18550-1-git-send-email-jingjing.wu@intel.com> <1457580346-18550-8-git-send-email-jingjing.wu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 07/12] librte_ether: extend flow director struct X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Mar 2016 11:45:57 -0000 Hi Jingjing, 2016-03-10 11:25, Jingjing Wu: > This patch changed rte_eth_fdir_flow from union to struct to > support more packets formats, for example, Vxlan and GRE tunnel > packets with IP inner frame. I think we need a lot more explanations about how it should work. >>From this point we should collect some acknowledgements from the maintainers of other drivers having this kind of flow steering need. Maybe that a better API, more generic, is possible. > This patch also add new RTE_FDIR_TUNNEL_TYPE_GRE enum. OK to add GRE to the existing API. > Signed-off-by: Jingjing Wu > Acked-by: Helin Zhang [...] > /** > - * An union contains the inputs for all types of flow > + * A struct contains the inputs for all types of flow > */ > -union rte_eth_fdir_flow { > - struct rte_eth_l2_flow l2_flow; > - struct rte_eth_udpv4_flow udp4_flow; > - struct rte_eth_tcpv4_flow tcp4_flow; > - struct rte_eth_sctpv4_flow sctp4_flow; > - struct rte_eth_ipv4_flow ip4_flow; > - struct rte_eth_udpv6_flow udp6_flow; > - struct rte_eth_tcpv6_flow tcp6_flow; > - struct rte_eth_sctpv6_flow sctp6_flow; > - struct rte_eth_ipv6_flow ipv6_flow; > +struct rte_eth_fdir_flow { > + union { > + struct rte_eth_l2_flow l2_flow; > + struct rte_eth_udpv4_flow udp4_flow; > + struct rte_eth_tcpv4_flow tcp4_flow; > + struct rte_eth_sctpv4_flow sctp4_flow; > + struct rte_eth_ipv4_flow ip4_flow; > + struct rte_eth_udpv6_flow udp6_flow; > + struct rte_eth_tcpv6_flow tcp6_flow; > + struct rte_eth_sctpv6_flow sctp6_flow; > + struct rte_eth_ipv6_flow ipv6_flow; > + }; > struct rte_eth_mac_vlan_flow mac_vlan_flow; > struct rte_eth_tunnel_flow tunnel_flow; > }; Please explain somewhere how to use this API change in order to have more discussions with other maintainers. I'm sorry to comment this change only now. I took time to realize that we need more consensus about the filtering API to make it usable by more drivers. For the 16.04 release, I suggest to remove this change from the series. Thanks for your understanding.