From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 876912C2F for ; Mon, 27 Jun 2016 17:19:45 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id v199so104718545wmv.0 for ; Mon, 27 Jun 2016 08:19:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=PKbrG2TLrvP/9iLwb1ubHe9cKRhI+vabmc2eU/Q6UiQ=; b=I1WbU3lWnOpiQ/YAcTOrYu1P3wu6fZyaSfxj08WyaHnPaznDEvc1j4ZgpTlNk4UUrp 1xxpN1Iw1tYusUUbFqFp0cPjOkkBwR8eXvsqWZ7TJwhFXkemOSsyQhJZWCiE4Heac4gC H1HnI2bRotq2ro4K/j0n0MirSnqrCF1Ff8YK+s6XNwd59ONSt5BZW2jXTt5LPgEckr5z k13P08nAmXhLxImc0grg0Kv4mA/NyFnAJuwEYo4ghk2Cf+iRuvUDm9+VRT6Jhd/xRgIa ld3Hc3e8I2H9lkQrSh1gY3xmpdtp64pSI+qaogLsm9JINTiZqFfC72S/R6yK7kZAytAs lVMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=PKbrG2TLrvP/9iLwb1ubHe9cKRhI+vabmc2eU/Q6UiQ=; b=SXZHsW6X1gkw8r7jjpso+xmFKSvDLK9bC68I2IZD3wG4HoJ0fjaZ3/g1J2tk4E2nPU WBoOQcJ30ZP46EUe/DJMpETPgUDqz/zAYBD5GdGaqA+j51We/iFpHfKw0lWcRed7/SSS y+cD8CdG6jqsyhmO0qBzLHEjdo/Hrf4SA8+6D6ltQxIB5hyhbdYB8rMabeVSMDD3V8eo 9RN5qbzWTt6zJ+boa7URkwZ0qIJI8Xg6HYK1SpcCfBeZHQRgsBUQKYUIv1CghwDYsxMa cFhMl8HAZ9p+0kObwpCr5ffqyRxRJBuiuMELunmwq8gd/V+Urrl61kelSGtIsdYrss6u biow== X-Gm-Message-State: ALyK8tIxFGEyFpx4g4eGn3JZgou4BW4M9AChFS4TlBnt6m/fEpIeoO8KWkmqNDtdghQDThEB X-Received: by 10.28.143.212 with SMTP id r203mr10814906wmd.35.1467040785363; Mon, 27 Jun 2016 08:19:45 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id e69sm12206292wma.2.2016.06.27.08.19.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Jun 2016 08:19:44 -0700 (PDT) From: Thomas Monjalon To: zr@semihalf.com Cc: remy.horton@intel.com, wenzhuo.lu@intel.com, helin.zhang@intel.com, konstantin.ananyev@intel.com, jingjing.wu@intel.com, dev@dpdk.org Date: Mon, 27 Jun 2016 17:19:43 +0200 Message-ID: <2151797.UCVmFz2S8u@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1466688410-13826-1-git-send-email-zr@semihalf.com> References: <1466688410-13826-1-git-send-email-zr@semihalf.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 1/2] ethdev: remove get_reg_length callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jun 2016 15:19:45 -0000 2016-06-23 15:26, zr@semihalf.com: > From: Zyta Szpak > > Version 4 of fixing the assumption of that device registers > are always 32 bits long. rte_eth_dev_get_reg_length and > rte_eth_dev_get_reg_info callbacks did not provide register size > to the app in any way. It is needed to allocate proper number > of bytes before retrieving registers content with > rte_eth_dev_get_reg. This commit remove rte_eth_dev_get_reg_length > callback and adds width parameter to reg_info struct which makes > it possible to call rte_eth_dev_get_reg_info to get attributes > first. The drivers using this callback fill width and length > when call to function made with data=NULL. > > Signed-off-by: Zyta Szpak Please do not mention patch revision in the commit log. However you can add a changelog below the three dashes (with --annotate). And please use --in-reply-to to keep revisions in the same thread. Thanks