From: David Hunt <david.hunt@intel.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>, dev@dpdk.org
Cc: reshma.pattan@intel.com
Subject: Re: [dpdk-dev] [PATCH v2] l3fwd-power: make interrupt wakeup log thread safe
Date: Wed, 7 Oct 2020 16:06:25 +0100 [thread overview]
Message-ID: <2151ec7a-8083-b4e0-41e2-18297a68d9c9@intel.com> (raw)
In-Reply-To: <e443e130a0aca99f0e03b727b1796e19479bdb07.1601640423.git.anatoly.burakov@intel.com>
Hi Anatoly,
On 2/10/2020 1:07 PM, Anatoly Burakov wrote:
> Currently, the interrupt status notification prevents log spam by
> remembering whether previous interrupt wakeup was due to traffic or due
> to timeout expiring. However, it is a single variable that can
> potentially be accessed from multiple threads, so it is not thread-safe.
>
> Fix it by having per-lcore interrupt status.
>
> Fixes: f4d1e19c293d ("examples/l3fwd-power: add Rx interrupt timeout")
> Cc: anatoly.burakov@intel.com
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
Makes sense. Thanks.
Acked-by: David Hunt <david.hunt@intel.com>
next prev parent reply other threads:[~2020-10-07 15:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 12:03 [dpdk-dev] [PATCH] " Anatoly Burakov
2020-10-02 12:07 ` [dpdk-dev] [PATCH v2] " Anatoly Burakov
2020-10-07 15:06 ` David Hunt [this message]
2020-11-02 10:35 ` Xie, WeiX
2020-10-09 6:26 ` Xie, WeiX
2020-10-30 12:46 ` David Marchand
2020-11-02 10:46 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2151ec7a-8083-b4e0-41e2-18297a68d9c9@intel.com \
--to=david.hunt@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).