From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1892CA04BA; Wed, 7 Oct 2020 17:06:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EC8B41BC86; Wed, 7 Oct 2020 17:06:32 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id E5A881BC84 for ; Wed, 7 Oct 2020 17:06:30 +0200 (CEST) IronPort-SDR: Ni3FfluRjCySTgIptCuUEot/i7B4IA8lt7WowskgXxCjC+81JUDfYK+35Sld/MP2zNBj0gmBC3 dUj3ay4CndyA== X-IronPort-AV: E=McAfee;i="6000,8403,9767"; a="144360787" X-IronPort-AV: E=Sophos;i="5.77,347,1596524400"; d="scan'208";a="144360787" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2020 08:06:28 -0700 IronPort-SDR: dvSdkmQQ9yHbKV+sg6h2O76xDDLK/2Qr5QfFPAIwTTxfKi97Y68FB5S2rN4CsiiNhaW0Gzy185 w9pV9e812r5Q== X-IronPort-AV: E=Sophos;i="5.77,347,1596524400"; d="scan'208";a="461357047" Received: from dhunt5-mobl5.ger.corp.intel.com (HELO [10.213.240.197]) ([10.213.240.197]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2020 08:06:27 -0700 To: Anatoly Burakov , dev@dpdk.org Cc: reshma.pattan@intel.com References: From: David Hunt Message-ID: <2151ec7a-8083-b4e0-41e2-18297a68d9c9@intel.com> Date: Wed, 7 Oct 2020 16:06:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Subject: Re: [dpdk-dev] [PATCH v2] l3fwd-power: make interrupt wakeup log thread safe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Anatoly, On 2/10/2020 1:07 PM, Anatoly Burakov wrote: > Currently, the interrupt status notification prevents log spam by > remembering whether previous interrupt wakeup was due to traffic or due > to timeout expiring. However, it is a single variable that can > potentially be accessed from multiple threads, so it is not thread-safe. > > Fix it by having per-lcore interrupt status. > > Fixes: f4d1e19c293d ("examples/l3fwd-power: add Rx interrupt timeout") > Cc: anatoly.burakov@intel.com > > Signed-off-by: Anatoly Burakov > --- Makes sense. Thanks. Acked-by: David Hunt