From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9D1E5A0C41; Thu, 16 Sep 2021 09:57:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 247154003F; Thu, 16 Sep 2021 09:57:34 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id A795D4003E for ; Thu, 16 Sep 2021 09:57:33 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 22DB45C01B9; Thu, 16 Sep 2021 03:57:33 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 16 Sep 2021 03:57:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= g3m04FjRA0dYAhDRNUXERG/4dA7yDOqe932BYmOH0I4=; b=VHo7fiRiTXC3TP7R HTf9IBW+1ZKiDO4l5x52jOn9gs663uAjU4gJDNjIRan6mKSZ6/o3rtl/zG8ZX4df +R7cNxOlYFS/WTc2YvG2RJugpgMTvqHMQ2tHg6HDsc3YaV5yZ5oK3zhHudf3VGDK n4sYKgBUsZuHdQPKOuZd7BV10qfH/mqWMiS/XltyCM9oUWk5xQqtDe7yq4cvss4O ufbvntNEzdkD5HhiiCiCcCcwTvBxBxRD5poYxzQhmFxj2Yaywre5HNivG6z3cJFS T38IqR2CGx8LX0d8QPLdc2259OqoL5fAGYbAh4KFnWD/7h1v74RFb041kdG/QW/F wH3k+A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=g3m04FjRA0dYAhDRNUXERG/4dA7yDOqe932BYmOH0 I4=; b=uGHPVIMUvh5DKtGofp5/a9hZyGwcYtr8GaHmc8qsg3lWuSVGncF98RL8o S9UP1T5qPESwe6SE4ckqU0J/HMCCIdpicQg93XnZt2MCiJe7lZorXvlw675d2C69 PUyWwNY/vrf5WOcqhH3cMLOMaKNUZSsXgjF1nDG+tj+CVqYF9uR8Ny9ztZm7PEuH B8peUnwiVE1Pf8DccdgBb8Tf8jPWE6reRAHvmHR82THPRJgAq5biaSV0L4PaewXC OyhB8PB0kqr7z2QZj0+Terkn/qft6Nr/XDsO4ur2opzTlyEtBqQzBeSErjS/CSIZ TNlfpKTt8eQaeDiErb3RPk1PF80Qw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudehfedguddvfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 16 Sep 2021 03:57:32 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, david.marchand@redhat.com Date: Thu, 16 Sep 2021 09:57:30 +0200 Message-ID: <2152077.EyU4qHBnM4@thomas> In-Reply-To: <20210915095036.22346-1-bruce.richardson@intel.com> References: <20210915095036.22346-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] doc/contributing: add line continuation note to meson guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 15/09/2021 11:50, Bruce Richardson: > Add a note for the preference of using "()" rather than "\" for line > continuations in meson. > > Suggested-by: David Marchand > Signed-off-by: Bruce Richardson > --- > doc/guides/contributing/coding_style.rst | 10 ++++++++++ This is not the Meson guide. > --- a/doc/guides/contributing/coding_style.rst > +++ b/doc/guides/contributing/coding_style.rst > @@ -1024,6 +1024,16 @@ The following guidelines apply to the build system code in meson.build files in > * Line continuations should be doubly-indented to ensure visible difference from normal indentation. > Any line continuations beyond the first may be singly indented to avoid large amounts of indentation. > > +* Where a line is split in the middle of a statement, e.g. a multiline `if` statement, > + brackets should be used in preference to escaping the line break. Should we specify it is about Meson? > + > +Example:: > + > + if (condition1 and condition2 # line breaks inside () need no escaping > + and condition3 and condition4) > + x = y > + endif > +