From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 32B2EA0526; Tue, 21 Jul 2020 15:07:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8E9201BFEE; Tue, 21 Jul 2020 15:07:36 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id E075D1BFEB for ; Tue, 21 Jul 2020 15:07:34 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 795E05C011A; Tue, 21 Jul 2020 09:07:34 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Tue, 21 Jul 2020 09:07:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= hjWUWdHPVdHSB5PgICgKoTB4o+BlYPLKphW5iCdZlY4=; b=PUdmsjXvtuvDNY5l 6Nhr79IjIs9uqMe9smrtWp827aP9fYgxt1LVozc43Qm2RG01fi5bHBK2x2C5Y0Zx BXn0ut95j0FGySXvTE4VOuZw/qBRmvWRk56O3b/8ND4bspnzcARBwJ4S/nHN9g9u MTn6QUxhVZRmrUu5psIjM8yR6Dy5Vv+n0SpprR3RHDIPkvzrLXxdSukrLqkNEAO6 x+VrZasu43fsifnG6dP1SqoLo+z5TqEM4qKClWNc+lKCUTTBnA3I34uh3v+ylcQ5 W+z9Eb/E74YOjo+9y32RqxiBz6s1V0Rp2l+SkC+AuUkSGklO1Oq8oFxSzujrhYVy k39zqA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=hjWUWdHPVdHSB5PgICgKoTB4o+BlYPLKphW5iCdZl Y4=; b=ReuK02oX3oKJJtvBEsR+LKWxXS3fE/1Co0kyCxEafIvdJhyAz2yJUiOT+ fu6Nh4GTK01ElJUJgquFK7ZhLAeNC6/2/q1d9yPrytrogPhm/XklsAAE+2Y4Cn2B 7J2L9B/M4z3aUEWKyL2c9t0R4YJCToaapTjucSYYUVcS/1wTE9V+zOpM0MQGda5u /7hyrhN8xsvfF0Uq1RJLtnBmhJ2TOoOJTI9aDDf/MIGW6FtHAbp9g19OytABkaxN AQWJ3W7cIQa9hLcSDBeSVbY8TJ+yx1XLJQtTFjG9fkFXFJwE7Z/rZWEItUHE41aW /QYURAz1gFTIcceppG2nZAbHFrr3w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrgeeigdehjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B847C3280063; Tue, 21 Jul 2020 09:07:31 -0400 (EDT) From: Thomas Monjalon To: Parav Pandit Cc: David Marchand , "dev@dpdk.org" , Ori Kam , Ferruh Yigit , dev , Gaetan Rivet , Raslan Darawsheh , Matan Azrad , Joyce Kong Date: Tue, 21 Jul 2020 15:07:30 +0200 Message-ID: <2152358.xQpQhIA9XB@thomas> In-Reply-To: References: <20200610171728.89-2-parav@mellanox.com> <6790966.1uoSfovWKA@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v7 2/9] eal: introduce RTE common initialization level X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 21/07/2020 14:51, Parav Pandit: > > > From: Thomas Monjalon > > Sent: Tuesday, July 21, 2020 5:57 PM > > > > 21/07/2020 14:13, Parav Pandit: > > > From: David Marchand > > > > On Tue, Jul 21, 2020 at 1:19 PM Parav Pandit > > wrote: > > > > > > This way, net/mlx5 and vdpa/mlx5 will pass their id_map to the > > > > > > mlx5 pci driver whether it is registered to the pci bus or not yet. > > > > > > > > > > And here pci_id_table will not be const *. > > > > > Is that ok? > > > > > > > > This is already the case in the current patch. > > > > I see nothing wrong with it. > > > > The pci code expects this pointer to be const and will it treat it as such. > > > > > > > o.k. > > > > > > Gaetan, Ferruh, Thomas, > > > Can you please ack as well? > > > > Yes of course it is OK updating the PCI table of the common layer in runtime. > > The most important is to keep the fixed PCI table of the PMDs the same as > > registered for pmdinfo usage. > > o.k. pci id table registered with PCI bus will be build dynamically, similar to how its done in v7. > Instead of doing it in constructor of mlx5_pci_bus, it will be done inside rte_mlx5_pci_bus_register(). > Right? Yes > And since we don't register it as rte_bus, shall I name it as rte_mlx5_pci_driver_register()/unregister(). > Right? Yes, if merging code in the common driver, no need to keep "bus" wording.