From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91930A04DD; Wed, 28 Oct 2020 11:08:57 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 72D50C908; Wed, 28 Oct 2020 11:08:56 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 4E03CC8FA for ; Wed, 28 Oct 2020 11:08:54 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id BA7905C00A5; Wed, 28 Oct 2020 06:08:52 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 28 Oct 2020 06:08:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= j4YCTwXcaMSlAXqw+Hy+yIz7repX/hnJDu7aaSPia/c=; b=PBUYnCTnQm8xb0K7 nQ1+4VBONApmsVDo6wUekfUzMTQAGlRW3hPEAw+oXg0aZnCjuDeaOxIjrJ0OGBAu JeZtMAtOUgebvn/nncz7l8I4tIEk4oi3wWApOkyo/H504chUFrCv+A4g/PLpHcd3 wKDTx1ZM58AdJLXxjEAGwLkZtwrQpnLTzJ3P/Uj0T3B4ovth4i46Fvi/U2v6v1qm sqe2lkktH6PiJB9TaAqdNBqY8gKVtFZnuGPwcTFN+vdFSxauBgjSarUUxsvCNlsM KDb2TK5ZOQW7D13pnWydr+SWao3kWvKM6Zjju3E2NA80JFHs0GpMz+WNgkxCnw+r ddbBvw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=j4YCTwXcaMSlAXqw+Hy+yIz7repX/hnJDu7aaSPia /c=; b=Z/VafQiXwqrFagOTev7ce2GIYOHpnoGWSxybCGDPNcqla7O9qvxb6ywSw oQONsDR5r6J/xEyWmkcLrwyRaNgMBTSfnSsBxJaoWsUs9EyhpopGjWns1wtMDUge eIovoXoYcH0NGpabDawUubGfVD+Y3C4MqMZkIsfS0fCpysOkwGt3N1Ua+MIgM5qS EsLTN83r24OwACvPHlJFkOsISpiXLly3y8sskaI1JdDERGccaKNHp2md9HAYpdwy 80/qQ4BDo9l0KG2L2ge8FdPwfmt70jzzsZpFGniNsakolu6gMv4ocNkd11ocAnhI 3rTpufM1Ef5aNNGiZWWY3H8zneIUQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrledugdduudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id BA0E73280060; Wed, 28 Oct 2020 06:08:50 -0400 (EDT) From: Thomas Monjalon To: Nithin Dabilpuram Cc: Pavan Nikhilesh , Jerin Jacob , Ruifeng Wang , Bruce Richardson , Konstantin Ananyev , kirankumark@marvell.com, dev@dpdk.org, david.marchand@redhat.com, olivier.matz@6wind.com Date: Wed, 28 Oct 2020 11:08:47 +0100 Message-ID: <2153992.0QQoBXgI6F@thomas> In-Reply-To: <20201028093003.29564-1-ndabilpuram@marvell.com> References: <3705096.qAGAdPRMt2@thomas> <20201028093003.29564-1-ndabilpuram@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4] node: switch IPv4 metadata to dynamic mbuf field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 28/10/2020 10:30, Nithin Dabilpuram: > From: Thomas Monjalon > > The node_mbuf_priv1 was stored in the deprecated mbuf field udata64. > It is moved to a dynamic field in order to allow removal of udata64. > > Signed-off-by: Thomas Monjalon > Signed-off-by: Nithin Dabilpuram [...] > + IP4_LOOKUP_NODE_PRIV1_OFF(node->ctx) = node_mbuf_priv1_dynfield_offset; That's interesting. You copy the offset in the node context for better performance. How much is it better than with global offset variable? How much it decreases compared to a static mbuf field?