From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 0162B9145 for ; Thu, 25 May 2017 05:48:15 +0200 (CEST) Received: by mail-wm0-f41.google.com with SMTP id 7so79170664wmo.1 for ; Wed, 24 May 2017 20:48:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=weka.io; s=google; h=from:to:cc:subject:date:message-id:organization:in-reply-to :references:mime-version:content-transfer-encoding; bh=7D287kL2plKUd9v/pEvE5cHINZViQQDk4FE2QligAvk=; b=5DHVXHqizt5UzjdKAmQXc7hawW0If2cRE1RdcR6pOpfycL1PMh94jbItGyNZImWA+o peT9kVWxmpuE+2bEZKxJf+Pw5LcefOZq/sbI0MbQq7RxJO6f1U6KwVgKDJwgJ/esWDgq MqK+QDKKdi4r51jYqV1iEQRj2Md4OQiuE1O3E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :in-reply-to:references:mime-version:content-transfer-encoding; bh=7D287kL2plKUd9v/pEvE5cHINZViQQDk4FE2QligAvk=; b=Zvf1IUvGHOphUVLpr8J+MDSrMDgADkGcqmbo5V2n6ZLJcnoJsSxWj4St+akuUXoKoz lEO+zxC+qI4VQU34HMlM/G94jGVWSi80YkZ/RJrosMt1w8wH7ixdTxUEs03esWpdhllu x1njZ+2ZFoxHJVBe6uYeZOdrGAqFJpm49IipZkUobkk1W/jHyJqn+aEZmnbaB/4xPiUm 0E/PN2DizBMxBRbDvXL67P8F4JCwOJAv14V/n9vvpXvnoJSPSo/vnS40IKpHxt4vtb7I uLI+lMiZ550vIM6EyYfe3LabEAlbo9whuxzUgnVnwwEKN4vAtksyVOon3PDAsIsEqvcT NEYA== X-Gm-Message-State: AODbwcDASFfuoxAVvJZ4VOSKAq6dtlgwDJU+0oEF0nfbrjY/3dVm1l9V j1n9r0jUyZrYKESdHyw= X-Received: by 10.28.130.213 with SMTP id e204mr7726556wmd.33.1495684095697; Wed, 24 May 2017 20:48:15 -0700 (PDT) Received: from polaris.localnet (bzq-82-81-85-138.red.bezeqint.net. [82.81.85.138]) by smtp.gmail.com with ESMTPSA id q108sm8120088wrb.3.2017.05.24.20.48.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 May 2017 20:48:15 -0700 (PDT) From: Gregory Etelson To: Olivier Matz Cc: dev@dpdk.org, users@dpdk.org, Ferruh Yigit , wenzhuo.lu@intel.com, "Dai, Wei" Date: Thu, 25 May 2017 06:48:13 +0300 Message-ID: <2154318.OTqaY7qzf9@polaris> Organization: Weka.IO In-Reply-To: <20170524152647.3499551d@platinum> References: <8509342.3MbcxIPMKs@polaris> <20170524152647.3499551d@platinum> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] IXBGE VF: link state detection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 May 2017 03:48:16 -0000 Hello, After the revert, my environment reproduced link up detection failure almost immediately With the patch the fault is rare. Regards, Gregory On Wednesday, 24 May 2017 16:26:47 IDT Olivier Matz wrote: > Hi Gregory, > > On Wed, 24 May 2017 12:50:19 +0300, Gregory Etelson wrote: > > Hello, > > > > In my tests DPDK-17.05.0 process queries link state with rte_eth_link_get() each 50 msec > > during 5-20 MB/sec IOs flow. > > I turn Ethernet switch port down and up and check IXGBE VF PMD reaction to link state changes. > > VF PMD correctly recognize link down events but may miss link up. > > When the fault occurs, subsequent calls to rte_eth_link_get will return link_status == 0 forever. > > I need to reset DPDK process to get correct link state value. > > My debugging shows that in case of the fault, mbx->ops.read(hw, &in_msg, 1, 0) in ixgbe_check_mac_link_vf > > keeps returning non-zero value > > It looks there is at least one issue with > commit c12d22f65b13 ("net/ixgbe: ensure link status is updated") > > Someone already complained about a problem related to the link status > on ixgbe (which is probably different than yours): > http://dpdk.org/ml/archives/dev/2017-May/066238.html > > Anyway, maybe you can try to revert this patch and see if it > solves your issue? > > Thanks > Olivier >