From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
[66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 105001B5DD;
Tue, 17 Oct 2017 22:33:57 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id 53A1820BB5;
Tue, 17 Oct 2017 16:33:57 -0400 (EDT)
Received: from frontend1 ([10.202.2.160])
by compute1.internal (MEProxy); Tue, 17 Oct 2017 16:33:57 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:content-transfer-encoding:content-type:date:from:in-reply-to
:message-id:mime-version:references:subject:to:x-me-sender
:x-me-sender:x-sasl-enc; s=mesmtp; bh=2O9X6DE4tmrG1P+jEMLjSSb5GG
fjmOOJSV/tzDGIyRM=; b=eOz5gIceR05oObsrRSo5FQGO8HXu1tnwbbTpPC3Ae6
7M8wplN9AAxLqK8dA4l2btQyoFvBnyTqOt6goaXPK19t/WOqyK2bqvssosdDHlJL
2Z2FagnZaVBpN8vEvzr4TrVfIOeiA+zrqd2urPzbOCtg5eENSabBXmp2/W9nsFsM
U=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=2O9X6D
E4tmrG1P+jEMLjSSb5GGfjmOOJSV/tzDGIyRM=; b=fQ2Sfshj3Z3LcHkl+kffz3
KOlmYlq++TTjoxUMlIIAqzadf+oOXJHmvtVjtirOW9iXMB5s8P+kXis8U1cdUIAs
Gc07jWt9XiPUkRlZR4j60/qXzcCq2uMQXdrbwXPOws04ZCdg+46Db9d88hoJHWux
Lop6UB0fYq2Lr/o3cUb+i3xRyKORsXQaFJxp8SDsik6/FOKcPTgerhcxRXPg+YdU
GhsUhomlFX1gSjnwig+dNiID71V99UjrFO8WnMqVdsW5/C/GuJVozuTA/bOq7a12
s+hvI3UMXgPTKnlEQI3oEoN1GRtYOo0W7zLERANd427DviRmzUDPchjMg9M+4P+Q
==
X-ME-Sender: <xms:NWnmWZtyIRs5cE4MFpvGqI8wqYgCLgmiqe_1GFkRytFPmM6_dyc4mw>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id F02477FA7D;
Tue, 17 Oct 2017 16:33:56 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
Harish Patil <harish.patil@cavium.com>
Cc: dev@dpdk.org, Jianfeng Tan <jianfeng.tan@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Shijith Thotton <shijith.thotton@caviumnetworks.com>,
Gregory Etelson <gregory@weka.io>, George Prekas <george.prekas@epfl.ch>,
stable@dpdk.org
Date: Tue, 17 Oct 2017 22:33:56 +0200
Message-ID: <2156540.XK3Rr5JXAh@xps>
In-Reply-To: <20171017201436.65270-1-ferruh.yigit@intel.com>
References: <20171017201436.65270-1-ferruh.yigit@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] igb_uio: revert open and release operations
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Oct 2017 20:33:58 -0000
17/10/2017 22:14, Ferruh Yigit:
> There were bug reports about terminated application may leave device in
> undesired state:
> http://dpdk.org/ml/archives/dev/2016-November/049745.html
> http://dpdk.org/ml/archives/dev/2016-November/050932.html
>
> And a proposal to fix:
> http://dpdk.org/ml/archives/dev/2016-December/051844.html
>
> Later another proposal triggered the discussion:
> http://dpdk.org/ml/archives/dev/2017-May/066317.html
>
> Finally a fix patch pushed into v17.08:
> Commit: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of device file")
>
> Later a regression report sent related to the pushed patch:
> http://dpdk.org/ml/archives/dev/2017-September/075236.html
>
> And a fix for regression integrated into v17.11-rc1:
> http://dpdk.org/ml/archives/dev/2017-October/079166.html
> Commit: 5f6ff30dc507 ("igb_uio: fix interrupt enablement after FLR in VM")
> Commit: 6b9ed026a870 ("igb_uio: fix build with kernel <= 3.17")
>
> Even after the fix qede PMD reported to be broken:
> http://dpdk.org/ml/archives/dev/2017-October/079359.html
>
> So this patch reverts original fix and related commits. The related
> igb_uio code part turns back to v17.05 base.
[...]
> ---
> It would be nice to solve this issue in LTS release, but being close to
> the release and the error report without details makes it hard to work
> more on this issue.
With this revert, we are back to the original issue.
We must really try the proposed solution.
Harish, please describe your issue and think how it could be fixed.
Jingjing made it work for i40e.
I know it is less effort to request a simple revert.
Please let's try to fix it once for all.