From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by dpdk.org (Postfix) with ESMTP id 6AE5E5A43 for ; Wed, 15 Jul 2015 12:32:12 +0200 (CEST) Received: by wiga1 with SMTP id a1so124691316wig.0 for ; Wed, 15 Jul 2015 03:32:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=QrOMG9X+WMCJasBOVtFPVP8n+OXBXmmo6J1r4jgHkpg=; b=KZEJjxcZL3sWVqRXbaBCS8CfXb+8L6rO5zZdpCdRDTG+ty4Hs8TMsDp/0pudqMignY 42GuvCt77SKtG5KZsndPSA+VENbQhWMu04e/JtWnQYRrBc5cMjMIlbDG9bljxSMt69QO I1N+SoK3bMk3zYZTsGHAlR0FUgFAHtNUiqUykT6Ots7NYWbkGusg15zZvTDh32We4Ng0 uo7/QkXok4eVoVLFUbegeh3tLubiR4FLik6cFws8Zkmmk60LHUMVxhfnijxJbATqU6Rw JDBzUVXiDuzl+Wo660rru97Bb6A7WokzeT5t/1myIhdOG14PJQ+qnzR2eE2oT6F5wirX bJ3w== X-Gm-Message-State: ALoCoQmcm5jxQ4mzlkLOEQZSFFnhJlv2sdzpL7Yi/J02aONZgktMqNuyOiPa29cp0oEy8hmAPKao X-Received: by 10.194.192.98 with SMTP id hf2mr6982197wjc.23.1436956332036; Wed, 15 Jul 2015 03:32:12 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.151.210]) by smtp.gmail.com with ESMTPSA id wx9sm7247558wjb.6.2015.07.15.03.32.10 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Jul 2015 03:32:11 -0700 (PDT) From: Thomas Monjalon To: "Wang, Liang-min" Date: Wed, 15 Jul 2015 12:30:59 +0200 Message-ID: <2157868.FlQ157duik@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: References: <1432946276-9424-1-git-send-email-liang-min.wang@intel.com> <10500550.BxuzPEpZpz@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v16 0/6] User-space Ethtool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jul 2015 10:32:12 -0000 2015-07-15 10:15, Wang, Liang-min: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2015-07-14 20:56, Wang, Liang-min: > > > Thomas, > > > The mac_addr_set is needed for ethtool net-op as described in > > > examples/ethtool-ethtool/lib/rte_ethtool.c > > (rte_ethtool_net_set/get_mac_addr). > > > > That's why it should be the first patch of this series. > > You probably misread "another patch" which means different patch in same > > series. > > > That's why this API and rest of API's added into librte_ether are all prepared in the same patch: 001. > I'm confused on your comment here. Are you asking me to break the patch 001 into two patches in the same series? > Meaning 001 and 002, would that be more confusing? Yes exactly. 001: mac_addr_set 002: reg/eeprom Thanks