From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6CF7EA0350; Thu, 25 Jun 2020 10:13:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D99E75B3C; Thu, 25 Jun 2020 10:13:17 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id C28632A66 for ; Thu, 25 Jun 2020 10:13:15 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 25C485C00B3; Thu, 25 Jun 2020 04:13:15 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Thu, 25 Jun 2020 04:13:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= PLKiLjEsGSN/hqpDp0RVaEhOjDD0h1ZbYTEigvxQmaQ=; b=ng8Th+vM30w2Gk/X GlS+dLF368CrY0WTSZjgITjUJxT5dWiKgTIqe1jlplAOjbkowFSBZBO2aPNePX+F R9Oyzi9n7xE3yrKIVbiGNPHflu8jhOjLKVOqckd+t0o/8ulS0DH6N/tZTsq2aUNJ mpn9oLH5PRVqfNLAglAAXxQlmNxFMzx5OFH/6GzfNI/RLdJbNstMLTXvZunARSgh Qx02ic9UkePEJhS+VWJds82x27OpZ4NjLCI6aZWk8f3nGkeRnqNjt8bVE2+G9Nj+ HCVseZLFSLhgJ+5BtjWIMi4DHwvioy524plk4qMJc2+NGObisLCA4rsKrnGiwkyd vRcaHg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=PLKiLjEsGSN/hqpDp0RVaEhOjDD0h1ZbYTEigvxQm aQ=; b=WEmqurBwDVrIT35Vu1/mKGRcsDSFGJjBfse5n/alYGovjItKK/VAyi8pI JcCQ+7NphYu2mrVK7GD1oeh17y25wBJlAyT0bW8VXSYZbxALS9H4LlTD6MAyE+4I KlfN0vMqpKZX/3aZcXL/c4g5VSurZ4qrfeuY1+0vhjsULSih4z8eiuwWj2iG93BQ iS2pxim6H1udbMGJgggH1Isrissyj/vsi/15OdQABuBdL81iD8WpkhLa7eVN/L7V shtls7A9fbrdogRmiGcUQFZCe3M2FuWtsfx8IkMDjjDV+zM3qnX62xGe+3mEqZbD yts+QjOqMi4DXXCXiKmPzNX43BOkg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudekledgtdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepgeejfffhhfeghfetveffgeffteelveekhffghfefgedvleeuveet fffgudelvefhnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucfkphepjeejrddufe egrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghi lhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 05F5E328005E; Thu, 25 Jun 2020 04:13:13 -0400 (EDT) From: Thomas Monjalon To: "Chautru, Nicolas" Cc: Akhil Goyal , "dev@dpdk.org" , "Richardson, Bruce" , "Yigit, Ferruh" Date: Thu, 25 Jun 2020 10:13:12 +0200 Message-ID: <2158398.uQ6CQvYSmG@thomas> In-Reply-To: References: <1585526580-113508-1-git-send-email-nicolas.chautru@intel.com> <3297014.iIbC2pHGDl@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 10/13] baseband/fpga_5gnr_fec: add configure function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 25/06/2020 02:30, Chautru, Nicolas: > > From: Thomas Monjalon : > > 02/05/2020 01:15, Chautru, Nicolas: > > > Hi Akhil, Thomas, > > > > > > Following up on that previous discussion below so that to confirm whether > > there is an available option to handle this usecase within DPDK repo. > > > > > > Basically traditional deployment for VRAN relies on BBDEV/DPDK running > > within container where the workload is processed behind BBDEV API bounded > > to a VF of the accelerator, all that is fully covered currently in 20.05. > > > Conversely an application from baremetal still has to be run at initialization > > to do the required register poking to PF MMIO so that to configure the HW so > > that the VF is functional. Without this it is not possible to use the VF driver > > form within the container. Said otherwise the BBDEV VF PMD cannot be even > > tested with DPDK repo (only the PF PMD with the workaround discussed in > > the previous discussion). > > > That small userspace application is purely doing mmap and writing to > > register based on xml file input (relying on igb_uio bounded to PF, or other > > vanilla kernel module) and has no dependency on rest of DPDK (DPDK would > > not be installed outside of the container since no packet or wireless workload > > is actually run from there). > > > Is that sensible to add such a small companion application within the > > related PMD directory even if it has no dependency on DPDK libraries per se, > > only the fact that is required just to be able to use BBDEV from the VF. > > > On one hand I see reason not to do this as this is not a DPDK application per > > se, but that companion HW application is still required to be able for anyone > > to use BBDEV driver + being within the same repo enforces that there is no > > risk of version mismatch. The other option being to put that on a separate > > repo outside of DPDK causing fragmentation of ingredients across repos. > > > > > > I wanted to check whether you had any strong opinion on this topic and > > whether a patch with such a companion simple user application may be > > approved. > > > > I feel it is best to have the required app in the PMD directory, as in "batteries > > included". > > > > Hi Thomas, > For such a companion application to configure the HW within the PMD directory I want to confirm two things before pushing a patch : > - This is okay with you for it to build outside of the DPDK build flow. Ie. Separate Makefile, not planning meson support. Again zero DPDK libraries dependency. I think it should be built as part of the PMD. Why not? > - This is okay with you for it to have dependency on other open-source library to build it. Ie. we are currently linking to this https://github.com/benhoyt/inih (BSD license) as a simple input config file parsing. No problem with dependencies.