From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 58A84FE5 for ; Tue, 2 Aug 2016 12:45:06 +0200 (CEST) Received: by mail-wm0-f48.google.com with SMTP id i5so283613000wmg.0 for ; Tue, 02 Aug 2016 03:45:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=j8YqJ3MDVLWW7BT2PsKXVd+ChtOmsbJzmeDsVewXsXc=; b=j0H3fcPUdq7AlAyTnMn1wPRm35zs4NUVV4oMH7kGD7WLmRdqFatTqDXuG4FkNxSY77 bEVQ34HBTH1GoThsiUT5yJ72o5b9tldZO6bih1COFfzCozOQdvVmkq6mG7k5brPlxG4c t3/He5xJfRJxppYqk4VbQb5vo5NTVaKUGT/7MVZ9SdERCJb7bfXl143Rbsga63+jLA3n iDbIeseE8xrwtsjPDUyAYycyPu+90/nP7up/6u34GOHjPtLEsd0at8RdARZeXjW+wJPP T1XuYepd/8XFko2ESpECA0QOBr4Y/QbLqoSiCSRQskyKutyVYuhJ46BrqQpNWdZEF+QT eZSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=j8YqJ3MDVLWW7BT2PsKXVd+ChtOmsbJzmeDsVewXsXc=; b=COtIQ0bQoap3Irp2LtkLc1Y4b+AkCH5O9kvApvtqjKVP8VZdqhHxJyHwqBAdEnaZri u1ez78Acw9RGkI69I7y78hVAZQsYjXpD2T/ZJ+gPgWZPl3ZM7bOIoweXFF6cQuiU0+sE tNqKuxjbcgBdtMtLO7o7Yznb/4ZG2Qd8JnNZ/rg2Bpe8maK/+65jUnL1+UBwYSMZHul0 zJvyNCcOCauGpnqr1VnpOuTF2nmb52Vzhm1VHN/T2L9kf8UH/KT3ow5H+T+YTy/zaFc2 y4VkCLkUYCM28VI6mIVMYwmIRn6tw3VZOhZE3ws7xLmP6YqMO1sDxZGfg9/F/JKdUzOg vYnQ== X-Gm-Message-State: AEkoousSgWmiUoxNW8LIq/Ftuybn65fp3K+Us5N7IT1psp2MKSld+Z/ITA3Xand8uL5cbnf4 X-Received: by 10.28.135.133 with SMTP id j127mr63423924wmd.9.1470134706059; Tue, 02 Aug 2016 03:45:06 -0700 (PDT) Received: from xps13.localnet (105.204.154.77.rev.sfr.net. [77.154.204.105]) by smtp.gmail.com with ESMTPSA id c8sm1998519wjm.19.2016.08.02.03.45.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Aug 2016 03:45:05 -0700 (PDT) From: Thomas Monjalon To: "Dai, Wei" Cc: dev@dpdk.org, "Yigit, Ferruh" , "adambynes@outlook.com" , "Liang, Cunming" Date: Tue, 02 Aug 2016 12:45:03 +0200 Message-ID: <2159818.VL9DW13Vyd@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <49759EB36A64CF4892C1AFEC9231E8D63A268522@PGSMSX106.gar.corp.intel.com> References: <1469081018-55300-1-git-send-email-wei.dai@intel.com> <1717702.2SVR8RdYDI@xps13> <49759EB36A64CF4892C1AFEC9231E8D63A268522@PGSMSX106.gar.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 4/4] eal: fix end character check in --lcores argument X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Aug 2016 10:45:06 -0000 2016-08-02 08:22, Dai, Wei: > Hi, Thomas, Yigit > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2016-07-28 16:26, Ferruh Yigit: > > > On 7/27/2016 12:27 PM, Wei Dai wrote: > > > > With --lcores 'a-b@c-d', eal_parse_cores() fails because > > > > eal_parse_set() fails due to the next character after lcore set a-b, > > > > which is '@'and not ',' or '\0'. > > > > There is also a right check immediately after this incorrect check. > > > > > > > > Fixes: 53e54bf81700 ("eal: new option --lcores for cpu assignment") > > > > > > > > Signed-off-by: Wei Dai > > > > > > I am not sure if a-b@c-d syntax should be supported. (a-b)@(c-d) is > > > supported and already working. > > > > Agreed. > > > > Series applied, except this last patch 4, thanks > > Sorry, I can't find any document to clarify whether a-b@c-d shoule be supported. > So I design following case to verify all kinds of combination of - and @. > I tested my patch with --lcores '0-3@12-15, 4-7@(8-11), (8-11)@4-7, (12-15)@(0-3), 16-19, (20-23) ', OK. So do you agree we can discard this patch and forget this syntax?