From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57B1FA04B4; Tue, 19 Nov 2019 14:53:24 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 87090A69; Tue, 19 Nov 2019 14:53:23 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 8FE031F5 for ; Tue, 19 Nov 2019 14:53:21 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id C38E8504; Tue, 19 Nov 2019 08:53:19 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 19 Nov 2019 08:53:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=ecHXzn3CnbjKOye8Nodx0EBqTChS6gXQW49qeoFazVM=; b=N42IXQJpPykI tN2q+LSLOHVwof2mUcoAN59u8ErS0sLZhX1sRZBnAth90wZm84ZLfm8LGelxqQCb DdWr/2GaObcziFehHI1dPHD3HawI5rmOadF1uPyEssbKWV1vSxkC3B80RqCAnIsd CrZB1E1C/JbeEUR1zZxkOPBbmawm2QA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=ecHXzn3CnbjKOye8Nodx0EBqTChS6gXQW49qeoFaz VM=; b=oR7poBZt976iECzDxsPR1bHQTgRrDA+wX1TtfbFObYXpgbF7DUT4Yry9V HVburH2Y+4NDySgwzPLOrQxpFbaQSm6o5xsVDlXDiogpREtrHWKJnlZ6WhpEejQ+ sf87i+wpCvmmE7wjAwE8JePsFzOlKbBdCHCepQlnAKARKOt1y2pwb6TklqWmJ5if rVwk3ae6QOvr5TNeeCEVluqgEvF+GLjJAHRK907LPQLqX2XFt6sMNWAQEqXl5z2n VN9hvXV9WMKIctdUrIfUGuDXLhlAiyY+IxRsdmrEQzLzGty819GAS+qwtMzBxNyk qe7ffXDUwni+jmhwKOibIBs/rKXrg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudegkedgheejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpeguphgukhdrqddqqdguvghvnecukfhppeejjedrudefgedrvddtfedrudek geenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnh gvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0B32E3060064; Tue, 19 Nov 2019 08:53:17 -0500 (EST) From: Thomas Monjalon To: Anatoly Burakov , Marcin Baran Cc: dev@dpdk.org, Bruce Richardson , john.mcnamara@intel.com, ray.kinsella@intel.com, david.marchand@redhat.com, Pawel Modrak Date: Tue, 19 Nov 2019 14:53:16 +0100 Message-ID: <2160256.76SxUoF7Yy@xps> In-Reply-To: <24aae2ed616a13f9597cc6059f0288ddd91bf359.1573230233.git.anatoly.burakov@intel.com> References: <24aae2ed616a13f9597cc6059f0288ddd91bf359.1573230233.git.anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v7 01/10] config: change ABI versioning to global X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/11/2019 17:25, Anatoly Burakov: > From: Marcin Baran > > As per new ABI policy, all of the libraries are now versioned using > one global ABI version. Changes in this patch implement the > necessary steps to enable that. For the history, would be nice to describe the "why" of each change here. Please do not be lazy :) > --- a/buildtools/meson.build > +++ b/buildtools/meson.build > +is_experimental_cmd = [find_program('grep', 'findstr'), '^DPDK_'] A comment is missing to explain the relationship between "experimental" and "^DPDK_". > --- /dev/null > +++ b/config/ABI_VERSION > +20.0 Why in config/ directory and not in root as for VERSION file? > + if is_experimental != 0 > + lib_version = '0.1' Why 0.1 and not 0.0? How do we increment the minor version of experimental libs? > + so_version = '0' How so_version is incremented? It would deserve a comment here. > if not use_function_versioning > - # use pre-build objects to build shared lib > + # then use pre-build objects to build shared lib Is this change relevant? > -option('per_library_versions', type: 'boolean', value: true, > - description: 'true: each lib gets its own version number, false: DPDK version used for each lib') Good to see this option removed.