From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0214545BB5; Wed, 23 Oct 2024 21:29:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C5C8140261; Wed, 23 Oct 2024 21:29:44 +0200 (CEST) Received: from fhigh-a1-smtp.messagingengine.com (fhigh-a1-smtp.messagingengine.com [103.168.172.152]) by mails.dpdk.org (Postfix) with ESMTP id A07FD40144 for ; Wed, 23 Oct 2024 21:29:43 +0200 (CEST) Received: from phl-compute-03.internal (phl-compute-03.phl.internal [10.202.2.43]) by mailfhigh.phl.internal (Postfix) with ESMTP id 18A21114020E; Wed, 23 Oct 2024 15:29:43 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-03.internal (MEProxy); Wed, 23 Oct 2024 15:29:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1729711783; x=1729798183; bh=H7Hc2fimPyDMwrs2RjJFD9EFHVuzJQfgcx2UeYY5dNg=; b= n7gh408noEJmbIVWuVT4Kg5njvWY2LVol28ulYlj5qEDbjlYiruwko7xMo/Qy3Aa PQjS6IkpXjxB2+ZfwZXG2TEw/rgXJuv5u8NmcV80biHPCBL/naUg54OgHuT6U+s2 T7j27Bo43OyeswZdSeTuTgR5YOGm/X1Ddy/lJGyuJCMtlKPI2gGoD/4KRal0l92c cXaifeCwufvCfEAcnH49SK1a+jdEihisc1TqW4I/6I5DNKt3ZwLbOz/wgSbpmmpB rhNJJFguzOFOzefvDkM3FD2eIJIZDmsu5K69P72UjlQoZ3j558BueHOH4GAFOeX0 a4HX1bzx/tKqD0G93r7uiw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1729711783; x= 1729798183; bh=H7Hc2fimPyDMwrs2RjJFD9EFHVuzJQfgcx2UeYY5dNg=; b=X Otlx7lo25XSTCUmyxNJ1jRK2dbeHzf+JLrXDH3sfjndGfNZ91jghHsfsiDOFa5kc pSNNvt9ez6KG2N406yWwRto7fQgXlqGd4Omc9Q1c+C9/qmsgRRYNbXf+ANC+05E6 9ChEvdlPoM37snyY0d5NFbfGBTNQaDOJJ0cOxglUlyMrQuEbuM9AsJexNl50E17/ KeL6Ris3wHoK9CB53527GbfLTuolItBRsLn3/ivGqkaJf8WW7tr7fT1PqxlUqcze dE+rj1Mg6EyAf9A/DwnelDMacFF4WD38YcFwI1EQCa8oeeDTGBC5gZF7IkJ1TQwL GTQeH4ZAedb3AlCsmCN6A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdeijedgudefiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttdej necuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjh grlhhonhdrnhgvtheqnecuggftrfgrthhtvghrnhepgedttdeljeejgeffkeekkedtjeev tdehvedtkeeivdeuuedvieduvdelveejueejnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthdp nhgspghrtghpthhtohepuddupdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehgrg hkhhhilhesmhgrrhhvvghllhdrtghomhdprhgtphhtthhopegurghvihgurdhmrghrtghh rghnugesrhgvughhrghtrdgtohhmpdhrtghpthhtohepuggvvhesughpughkrdhorhhgpd hrtghpthhtohepjhgvrhhinhhjrggtohgskhesghhmrghilhdrtghomhdprhgtphhtthho pehjvghrihhnjhesmhgrrhhvvghllhdrtghomhdprhgtphhtthhopehhkhgrlhhrrgesmh grrhhvvghllhdrtghomhdprhgtphhtthhopehsthgvphhhvghnsehnvghtfihorhhkphhl uhhmsggvrhdrohhrghdprhgtphhtthhopegsrhhutggvrdhrihgthhgrrhgushesihhnth gvlhdrtghomhdprhgtphhtthhopehhvghmrghnthdrrghgrhgrfigrlhesnhigphdrtgho mh X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 23 Oct 2024 15:29:41 -0400 (EDT) From: Thomas Monjalon To: Akhil Goyal Cc: David Marchand , "dev@dpdk.org" , Jerin Jacob , Jerin Jacob , Harman Kalra , Stephen Hemminger , Bruce Richardson , Hemant Agrawal , Sachin Saxena , Ferruh Yigit Subject: Re: [EXTERNAL] Re: [PATCH v3 3/9] raw/cnxk_rvu_lf: add PMD API to get BAR addresses Date: Wed, 23 Oct 2024 21:29:39 +0200 Message-ID: <2160624.o4kTbAZ4gJ@thomas> In-Reply-To: References: <20241008105415.1026962-1-gakhil@marvell.com> <3152317.f0I1acK8xe@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 23/10/2024 21:14, Akhil Goyal: > > 22/10/2024 14:06, Akhil Goyal: > > > > On Tue, Oct 22, 2024 at 8:06=E2=80=AFAM Akhil Goyal wrote: > > > > > > The rational to NOT pull "Hardware abstraction library using th= e BAR > > > > > > address" to DPDK are > > > > > > -Yet another 200K of driver C++ code which does not make sense = to keep > > > > > > in dpdk.org > > > > > > -It can not implemenent any of the current subsystems > > > > > > > > > > > > In this context, let me know what you think? > > > > > > > > This hardware abstraction library will have to call some driver > > > > specific API (like the added raw/cnxk_rvu API). > > > > Can this library directly use the PCI driver API, and call the cnxk > > > > common driver? > > > > If so, there is no need to add another driver API (that breaks > > > > layers), and the rawdev driver is only about adding the mailbox > > > > features. > > > > > > cnxk common has a lot of internal APIs which > > > we do not want to expose directly to application. > >=20 > > Actually the target is an out-of-tree driver, not an application. > >=20 > > > It seems the only contentious API is to get the BAR addresses. > > > All other APIs seems to be fine. Right? > >=20 > > Interrupt management is also something we would like to see reserved to= drivers. > >=20 > > > If so, we can remove that API and get the bar addresses as you sugges= ted > > below. > > > rte_rawdev_info_get() -> get rte_device -> RTE_DEV_TO_PCI -> get bar = addr > > > via bus_pci_driver.h header, exported via enable_driver_sdk option > >=20 > > Yes please, it is better to avoid confusion between driver and applicat= ion. > > Any driver type layer should be exposed only when the Meson option > > enable_driver_sdk is enabled. > >=20 > > You probably should export the interrupt functions in a separate file > > through driver_sdk_headers, so it is clear it is not an application lev= el. > > Does it apply to the mailbox functions as well? > >=20 > Ok, if we are having a separate file as driver_sdk_header, > We can also keep the BAR address API in that. Right? I think yes but it is redundant with the path rte_rawdev_info_get() -> get rte_device -> RTE_DEV_TO_PCI -> get bar addr Is it performance sensitive? In this case you could save/cache it.