From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id 970AE937C
 for <dev@dpdk.org>; Fri, 13 Nov 2015 17:01:08 +0100 (CET)
Received: by wmww144 with SMTP id w144so34567253wmw.1
 for <dev@dpdk.org>; Fri, 13 Nov 2015 08:01:08 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind_com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:organization:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding
 :content-type; bh=6jZrYaDLYm3IPqyEK1tD16ELNCZygvOlggXSAuR2QDk=;
 b=WDEtgSS6zZ/WuojlKXDG2UoDN3Ynfc2tCL20YHIybDs7QyZkuRHblQAjSGrox2qBrM
 Qpnb5O3iSxy94JuskhpvGlpuWb/c/xz3LmbGNf/HSzntpYOVz9mCatKJhsw1+wSXAy/L
 PRYtb9tp19xI/tabXTyibBgwbANsJVQjGezRcrXmKPaAON+OkmodioW+DK9BYUEzYIKE
 CkVK5H5JVfjmsHsYZWDXyLmNoNk3te5KeNLAgW3KMzcZhiOgoExe34wt6Epzh14scHdU
 2bi9+pgJxPQNwk2bQZEkhuRPrSB9WC6EO2e/h1sNA038Rj5GkNklY+I9k4W6TMK737lg
 E6Eg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=6jZrYaDLYm3IPqyEK1tD16ELNCZygvOlggXSAuR2QDk=;
 b=ChYufR442/qT40n7kg4cK4PXTlfWj42HLmHEOg+0rHNvUfQqtljI7lgoJh9uCYa5H4
 U/Uu7g2VDMOZ52xoHcekCIad9j0e4p0zQ6zZHG1oTpsLmLcye+5SxCtqsU87mlXz4zo2
 zVqvp8EZOGGvHygVJTLXzZKuBzVzQXRZ58mAj2kyS+BR2osMAfI+pbya88GJVQdsFk8p
 d8KY6MG3u/GVpw9wTxrfnruGlLwUwOpc3BPsZnJy//UN4GI64SzRHiOchlqSBfG7Prol
 6YZAaakDi8/pJAPnCVu2S3ZBFl+dGl0iKPAiZlepSlvR2HhjoqczLXZvF5w8kurjOF0H
 mA2g==
X-Gm-Message-State: ALoCoQngVK2Zl3E+Aj4l3SMyyaRBZqTLl8XPMd+/tnV7KysTRHAswvH8DONfiyQ7OFO2/8zf7D0i
X-Received: by 10.28.104.197 with SMTP id d188mr4957854wmc.55.1447430468400;
 Fri, 13 Nov 2015 08:01:08 -0800 (PST)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by smtp.gmail.com with ESMTPSA id pn6sm16292768wjb.15.2015.11.13.08.01.07
 (version=TLSv1/SSLv3 cipher=OTHER);
 Fri, 13 Nov 2015 08:01:07 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Declan Doherty <declan.doherty@intel.com>
Date: Fri, 13 Nov 2015 16:59:54 +0100
Message-ID: <21617013.7y6t1r3jyk@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <1447176763-19303-7-git-send-email-declan.doherty@intel.com>
References: <1447101259-18972-1-git-send-email-declan.doherty@intel.com>
 <1447176763-19303-1-git-send-email-declan.doherty@intel.com>
 <1447176763-19303-7-git-send-email-declan.doherty@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v6 06/10] mbuf_offload: library to support
	attaching offloads to a mbuf
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Nov 2015 16:01:08 -0000

2015-11-10 17:32, Declan Doherty:
> @@ -841,6 +844,9 @@ struct rte_mbuf {
> +
> +       /* Chain of off-load operations to perform on mbuf */
> +       struct rte_mbuf_offload *offload_ops;
>  } __rte_cache_aligned;

Why is there a pointer in the mbuf structure?
Can it be a metadata for the crypto layer instead?

More generally, I have the feeling that the idea behind this new API
is not enough explained. How is it related to the ethernet offloads?
Could you add a doxygen explanation starting with
/**
 * @file

About doxygen, please think to integrate your new header.