From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 25032A00C2; Thu, 6 Oct 2022 02:27:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C318240A82; Thu, 6 Oct 2022 02:27:43 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id 92A4B40697 for ; Thu, 6 Oct 2022 02:27:41 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id D7C80320027A; Wed, 5 Oct 2022 20:27:38 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 05 Oct 2022 20:27:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1665016058; x= 1665102458; bh=7HZ29z6mib7DXEjR/m/yUx2AAleJfxz+F+3JVC4zx14=; b=Q aDIpJ51y3tKv8aOW4jrGHcznV+gAyV8Ysim2/7LwHTVCHvOrJD+Se2AT7OU2a+KM CSkeTTCSQ4KPZRdEN+sSpZbRKj23HoaHNO6sylfNjZmUbfbG2SRADGP2iYIM+cio wrb48zqlXqW4pHQ3YQ5cCRN01cStxOeFhKI4PyZ9pvM5Co/i2HlRtAOpOomB0mrr 1YdsXVD6m8mDyMQI6fpAxzlc4p+tROjCRLHIfn/NhUbXpDpvX909YVNVxZsErZEB qDndFMdsqGTbG2LjX7MzC/afDzU6K3ayFK5k7QjCSX5usDJKJhqkouGX35TMW9MG S4A4DSEV9ARj+CntiLTbw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1665016058; x= 1665102458; bh=7HZ29z6mib7DXEjR/m/yUx2AAleJfxz+F+3JVC4zx14=; b=p eVozDzTn9i+wZZEDVBTiW2zRH+Pc/IKqU+abuXraevpVE3+CDYrRI6iPzSflPZwt /hI14NS8nudUovZ9KHRsCS9X6ZXAvx/vp2jqRkpV+zR8ZtcSYDO3CStuoD5r3+k7 8ULJgIMK+m3BQUjoUURri52V3BtoDTvWepqccEGxL76kS/28WnaJto6GHgC9FrGa FyYFF0dVyZ02sqEOijzLOjBBwQ+tsm7f/eWQmecnVVrVHq5H2NiU52wPy1cR5qVj zpwLNrCxtZqQKzAs49ql9dseFoPvwieRO4o52VbQLOCYRpZXGpDAE7RDS2naERsw Hgxm+MQxNUAVByktlO+Xw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeigedgfeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 5 Oct 2022 20:27:37 -0400 (EDT) From: Thomas Monjalon To: Tyler Retzlaff Cc: David Marchand , dev@dpdk.org, Stephen Hemminger , Morten =?ISO-8859-1?Q?Br=F8rup?= Subject: Re: [PATCH] eal: fix return type of bsf safe functions Date: Thu, 06 Oct 2022 02:27:35 +0200 Message-ID: <21625054.EfDdHjke4D@thomas> In-Reply-To: <20221005222005.GA9819@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <22501102.ssLaC8jLEa@thomas> <20221005222005.GA9819@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 06/10/2022 00:20, Tyler Retzlaff: > On Wed, Oct 05, 2022 at 09:41:26PM +0200, David Marchand wrote: > > On Wed, Oct 5, 2022 at 5:41 PM Thomas Monjalon wrote: > > > > > > In a recent commit, changing return type from int to uint32_t, > > > I did a last minute change to functions rte_bsf32_safe and rte_bsf64_safe, > > > because thought they were forgotten. > > > Actually these functions are returning 0 or 1, so it should be int. > > > The return type is reverted to the original type for these 2 functions. > > > > > > Fixes: 4b81c145ae37 ("eal: change return type of bsf/fls functions") > > > > > > Signed-off-by: Thomas Monjalon > > > > Reviewed-by: David Marchand > > Acked-by: Tyler Retzlaff Applied, sorry for the noise.