From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id EC6ECF94 for ; Wed, 20 Jul 2016 12:45:57 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id i5so62367432wmg.0 for ; Wed, 20 Jul 2016 03:45:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=tG4P2ti0S/ojYFarVPCwakPR36a3BqeMGR7gM8AbYEg=; b=MtlwUxwrzzVKQ2Mpzc+w494lBGO2fK1Iaoh3wDy6Fzv/+0v3YH8BSk8Mc8P+qpyuhl G01MVQcq4zqHoZR75TJ8sNMgpciu/6jrdng/oNkDhbcTvYa/4DaeupCEICHOxp9aidC7 bYD7RxwDWLSUmWpC47OnDammhniap1ITDpVMznpNg4qu5GFwoSLQ4KY2pO6RhVSlceoi tJxykNUfqCUBhszco1lEMo8pAor34JT/wy4H3HVMFPO39uhG0jWzavSLisMdjgLqLi43 ZTWXj1r7JBtIQHfvFWsaBsamBlWUpy/5s+gf+arOt9T6lw70VJsUZF3KUoshv4bQcup7 bTMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=tG4P2ti0S/ojYFarVPCwakPR36a3BqeMGR7gM8AbYEg=; b=enra6KQt0iQyAx4Uf1iIuMSaeCOg7XPvZs4TDQg5m8vKudztrSTeRaheN4O6j/91Bu P0jYbSjlMVzKo/ApBpNN1KYwqdoABPgiXaj5jFPbB/Up744lXHmGYPppCBIJmyFWXOF6 nutecxR8cbDb7jBNv9rbutvaeQ5rdYI2fTENeyNTOCl0zy4RySTZicspoO6f8mcC4b7d +RxE9QGDJ7ODVJrnZvuIbATecnjeuS4H6s8/Qphdrk3VqRsp19eVAPzancKtk7pkxmE4 qxbmjTbLCmCiL6tMk2BgFG7+a4bc1ZjZm+eRInhNDFHgVKJ2oz5LDh8aJDI2AMqaONEm VKHw== X-Gm-Message-State: ALyK8tLMXKc6HiUOKwtJoCqoFdM+QWCN9rfB6cA9jmHeTyAldQ2yvhT9R/cy6cC15LSibz90 X-Received: by 10.28.199.15 with SMTP id x15mr10270418wmf.96.1469011557663; Wed, 20 Jul 2016 03:45:57 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id cd5sm602605wjc.31.2016.07.20.03.45.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Jul 2016 03:45:56 -0700 (PDT) From: Thomas Monjalon To: "Wu, Jingjing" , Rahul Lakkireddy Cc: "Richardson, Bruce" , dev@dpdk.org, Kumar A S , Nirranjan Kirubaharan , adrien.mazarguil@6wind.com Date: Wed, 20 Jul 2016 12:45:56 +0200 Message-ID: <2163583.Cop1HCq0pZ@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <9BB6961774997848B5B42BEC655768F8DC9E41@SHSMSX104.ccr.corp.intel.com> References: <3876623.1zX8JlhDJf@xps13> <9BB6961774997848B5B42BEC655768F8DC9E41@SHSMSX104.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 01/10] ethdev: add a generic flow and new behavior switch to fdir X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jul 2016 10:45:58 -0000 2016-02-26 01:17, Wu, Jingjing: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2016-02-25 15:03, Rahul Lakkireddy: > > > On Wednesday, February 02/24/16, 2016 at 14:17:58 -0800, Thomas Monjalon wrote: > > > > > In our case, it is possible to match several flows > > > > > in a single rule. For example, it's possible to set an ethernet, vlan, > > > > > ip and tcp/udp flows all in a single rule. We can specify all of these > > > > > flows in a single raw input flow, which can then be passed to cxgbe flow > > > > > director to set the corresponding filter. > > > > > > > > I feel we need to define what is an API. > > > > If the application wants to call something specific to the NIC, why using > > > > the ethdev API? You just have to include cxgbe.h. > > > > > > Well, in that sense, flow-director is also very intel specific, no ? > > > > Yes. I think the term "flow director" comes from Intel. > > > > > What we are trying to do is make flow-director generic > > > > So let's stop calling it flow director. > > We are talking about filtering, right? > > Are you suggesting chelsio to define a new filter type? > > > Why is it so complex? We are talking about packet filtering, not rocket science! > > > The complex is due to different NICs different behavior :-) > As I know, it is a common way to use used-define data pass specific infor to driver. > > Even flow director is concept from Intel's NIC, but I think it is the generic one comparing > with other kinds of filters. So I think that's why Rahul choose it to add their kind of filters. > As I know enic driver also uses flow director API to support their filters. [...] > Any better suggestion? We have a more generic proposal now: http://dpdk.org/ml/archives/dev/2016-July/043365.html Rahul, does it fit your needs?