From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 21A1FA04DB; Thu, 15 Oct 2020 12:34:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0186F1DE74; Thu, 15 Oct 2020 12:34:16 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by dpdk.org (Postfix) with ESMTP id AB3041DC9B for ; Thu, 15 Oct 2020 12:34:13 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 4E0CFD77; Thu, 15 Oct 2020 06:34:12 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 15 Oct 2020 06:34:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= GgI18uMVBjvNzM7gfYi36tfGaaqFaHbfs2L2W414sLY=; b=mQcG4F/PGr0CgUnn Y6suAtm4DQnw1rN8Rga1jJ8R4aD7WbilmzKYG9HdRAc38k5peT/UayIlSjFeyddl /ZCWbsvznnHpGZPIXUIvrsar7wVCXGiGzuWiirql3LYKtOgMe4+Enwf1lRl2qOlk NFE1CAKCeb08zdupXMAiMyjYTSkjDYyVa2Ra/4Kw6OyxrqfQ+hDKC7j+GVHlweWI 9qDizs2TkFojPZn3kNKVenBCoKyY+HbSUBNtVU4F2K9FliFmrZNc5NztiW3MNNrp jwNcCrCBe9HPamERK1XqbJmQ1ow3lrivIrabyv77c5ewNdm7tMeN59NDsC4oEWMQ zSuQMg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=GgI18uMVBjvNzM7gfYi36tfGaaqFaHbfs2L2W414s LY=; b=Yz0k/UmXyrrBWxiTY9iCg6L/XMU3XIJEIoTQwfCa6L7QZb36hZASMv3yX qPyv/bmazbAty1hHKzBde+fPoHG+WSPSUP0NLEwAJEO0GSpHlhiKo5sqLU/rMMvX RzuOwYkXjAdQTL62rOMfU8A1MfvGzFXN2vRIGWomOD/JVcswbp523JdkHyqMSwU4 4WqL5/J2fPLhAqAZPYI4QcXpsHuwmcST5TyYlvMF8M6vvg97VHDvH40iehA8D74J WxExsRkaeLIeRJ3XvwbO/Y1SAfu6sGovFzOdpPMxE5Xqy/HeyF0nQTbInuwKDNsJ Xy7qgfmpQ00hUCf3IP7jkNYVy4c+A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrieefgddvlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 202D63064682; Thu, 15 Oct 2020 06:34:10 -0400 (EDT) From: Thomas Monjalon To: Bing Zhao Cc: orika@nvidia.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, mdr@ashroe.eu, nhorman@tuxdriver.com, bernard.iremonger@intel.com, beilei.xing@intel.com, wenzhuo.lu@intel.com, dev@dpdk.org Date: Thu, 15 Oct 2020 12:34:09 +0200 Message-ID: <2164152.BJDqhmbNaX@thomas> In-Reply-To: <1602740124-397688-2-git-send-email-bingz@nvidia.com> References: <1601511962-21532-1-git-send-email-bingz@nvidia.com> <1602740124-397688-1-git-send-email-bingz@nvidia.com> <1602740124-397688-2-git-send-email-bingz@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 1/5] ethdev: add hairpin bind and unbind APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 15/10/2020 07:35, Bing Zhao: > v5: > * Change EINVAL to ENODEV > * add newline character in the end of log line > * descriptions update It looks good. More minor coding style comments below. With those, Acked-by: Thomas Monjalon > + if (ret) Coding style recommends explicit comparison with == or != > + RTE_ETHDEV_LOG(ERR, "Failed to bind hairpin TX %d " > + "to RX %d (%d - all ports)\n", tx_port, > + rx_port, RTE_MAX_ETHPORTS); It is preferred not splitting the log lines, or maybe only after a format specifier, so it can be grepped. Here the space after %d would be better on the next line. In general Rx/Tx is preferred over the full capital RX/TX version. Thanks