From: Thomas Monjalon <thomas@monjalon.net>
To: Ruifeng Wang <Ruifeng.Wang@arm.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
"pbhagavatula@marvell.com" <pbhagavatula@marvell.com>,
"jerinj@marvell.com" <jerinj@marvell.com>
Cc: dev@dpdk.org, Jan Viktorin <viktorin@rehivetech.com>,
Bruce Richardson <bruce.richardson@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>,
Jerin Jacob <jerinjacobk@gmail.com>
Subject: Re: [PATCH] config/cn10k: align mempool elements to 128 bytes
Date: Sat, 12 Feb 2022 15:14:42 +0100 [thread overview]
Message-ID: <21642516.hxa6pUQ8Du@thomas> (raw)
In-Reply-To: <CALBAE1MBXTOaW7rvSCtk2sS930J1RsqArsQenMaiWKeKpmR2QQ@mail.gmail.com>
21/01/2022 10:37, Jerin Jacob:
> On Thu, Jan 20, 2022 at 3:21 PM Jerin Jacob <jerinjacobk@gmail.com> wrote:
> >
> > On Tue, Dec 14, 2021 at 2:53 PM Ruifeng Wang <Ruifeng.Wang@arm.com> wrote:
> > >
> > > > -----Original Message-----
> > > > From: pbhagavatula@marvell.com <pbhagavatula@marvell.com>
> > > > Sent: Monday, December 13, 2021 7:06 PM
> > > > To: jerinj@marvell.com; Jan Viktorin <viktorin@rehivetech.com>; Ruifeng
> > > > Wang <Ruifeng.Wang@arm.com>; Bruce Richardson
> > > > <bruce.richardson@intel.com>
> > > > Cc: dev@dpdk.org; Pavan Nikhilesh <pbhagavatula@marvell.com>
> > > > Subject: [PATCH] config/cn10k: align mempool elements to 128 bytes
> > > >
> > > > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > > >
> > > > Mempool elements are by default aligned to CACHELINE_SIZE.
> > > > In CN10K cacheline size is 64B but the RoC requires buffers to be aligned to
> > > > 128B.
> > > > Set RTE_MEMPOOL_ALIGN to 128 to force mempool buffers to be aligned
> > > > 128 bytes.
> > > >
> > > > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > > > ---
> > > > config/arm/meson.build | 3 ++-
> > > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/config/arm/meson.build b/config/arm/meson.build index
> > > > 213324d262..33afe1a9ad 100644
> > > > --- a/config/arm/meson.build
> > > > +++ b/config/arm/meson.build
> > > > @@ -276,7 +276,8 @@ soc_cn10k = {
> > > > 'implementer' : '0x41',
> > > > 'flags': [
> > > > ['RTE_MAX_LCORE', 24],
> > > > - ['RTE_MAX_NUMA_NODES', 1]
> > > > + ['RTE_MAX_NUMA_NODES', 1],
> > > > + ['RTE_MEMPOOL_ALIGN', 128]
> > > > ],
> > > > 'part_number': '0xd49',
> > > > 'extra_march_features': ['crypto'],
> > > > --
> > > > 2.17.1
> > >
> > > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> >
> > Applied to dpdk-next-net-mrvl/for-next-net. Thanks
>
> As per @Ferruh Yigit suggestion, This patch will be taken through the
> main tree.
> I changed state as New and Delegate as @Thomas Monjalon for this patch in pw.
>
> >
> >
> > Added
> > Fixes: 1b4c86a721c9 ("config/arm: add Marvell CN10K")
> > Cc: stable@dpdk.org
Applied
next prev parent reply other threads:[~2022-02-12 14:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 11:06 pbhagavatula
2021-12-14 9:23 ` Ruifeng Wang
2022-01-20 9:51 ` Jerin Jacob
2022-01-21 9:37 ` Jerin Jacob
2022-02-12 14:14 ` Thomas Monjalon [this message]
2021-12-14 10:30 ` Kevin Traynor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21642516.hxa6pUQ8Du@thomas \
--to=thomas@monjalon.net \
--cc=Ruifeng.Wang@arm.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinj@marvell.com \
--cc=jerinjacobk@gmail.com \
--cc=nd@arm.com \
--cc=pbhagavatula@marvell.com \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).