From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 56B351B37C for ; Tue, 7 Nov 2017 02:20:47 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id BFD1D202D4; Mon, 6 Nov 2017 20:20:46 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Mon, 06 Nov 2017 20:20:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=DISMXUqqvDCUv6+PkJ9mYNJepY rMPrc2I75wN9wte2c=; b=WpHdv8+2p1SfvyrWdRWoEVTGigONrDYln4zA2KT9Xt 1EAvleewaG/zAZNwSHbRhtGh64o8wxMCtpHMjb9mwtNuwDyUaG7c/GHjhsjxLAf2 /dOZCWqCM0So64RL7cOcdUprkDw1YIX4+Kox3b4CmQwc2f7bHKP784tM1KT2ZaMK g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=DISMXU qqvDCUv6+PkJ9mYNJepYrMPrc2I75wN9wte2c=; b=HE9+HNpQO1nPZ4mQzxVNsd Edv1D7WFHxliwrq4anf97xbwFrQRqlpHKC1I0olKDrUayFi3zpsNfnWQumLBDYF4 sFoTUZRm3DXmr2kRZlYiFuaGmGpetOl9lWHMgWXVfvezNyhYWQtcjNHdzHF+UXDI u6hAb5CTb6/s8J5PgApHJJhXEpO4F3Nv4XItDhUUiEZHdjUkN2LP8pU2ndsokuZT iDSPIOlhy2vuBby2ZccIAolqzh1MQNFF/SEw0VfjvsTOGzjl6gtoYPT9X6Wduko3 CDpCfocw2MBRZDfQ9GK1XiDFPDUXA9FcBOKHyIzxZgiMl38/EPjZ6kkjzgd09ZRw == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8498B240B2; Mon, 6 Nov 2017 20:20:46 -0500 (EST) From: Thomas Monjalon To: "Piasecki, JacekX" Cc: dev@dpdk.org, "Jastrzebski, MichalX K" , "Dumitrescu, Cristian" Date: Tue, 07 Nov 2017 02:20:45 +0100 Message-ID: <2164750.0ENp7ujehH@xps> In-Reply-To: <60ABE07DBB3A454EB7FAD707B4BB158213C4B1B1@IRSMSX109.ger.corp.intel.com> References: <1508998869-4963-1-git-send-email-jacekx.piasecki@intel.com> <60ABE07DBB3A454EB7FAD707B4BB158213C4B1B1@IRSMSX109.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] cfgfile: fix resource leak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Nov 2017 01:20:47 -0000 27/10/2017 17:08, Jastrzebski, MichalX K: > > > > Unsuccesfull memory allocation for elements inside cfgfile > > structure could result in resource leak. > > Fixed by pointer verification after each malloc, > > if malloc fail - error branch is proceeded with freeing memory. > > > > Coverity issue: 195032 > > Fixes: d4cb8197589d ("cfgfile: support runtime modification") > > Cc: jacekx.piasecki@intel.com > > Cc: stable@dpdk.org No need to Cc stable for bugs introduced in current release. > > Signed-off-by: Jacek Piasecki > > Acked-by: Michal Jastrzebski Applied, thanks