From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0EA9AA04BC; Thu, 8 Oct 2020 10:46:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C46AF1BAB6; Thu, 8 Oct 2020 10:46:39 +0200 (CEST) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by dpdk.org (Postfix) with ESMTP id C47FB1BAB5 for ; Thu, 8 Oct 2020 10:46:36 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 35F4A580223; Thu, 8 Oct 2020 04:46:36 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 08 Oct 2020 04:46:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= 8l3Cczc0yj1liMJe7ylAzSnkkR6+gikHqgQtuLlI0g0=; b=VW8/HYy1hre/ryn7 SQAbAx1BkevY/25+tAUIUr9+nXxeGjpcqkVnhSRhWGm3RxuDOFHYtWHOmmmpbVxr 3uSqPG61clVUZAG9D8S5ldB/LkmGMNqrkiY5mT6/AMlMNBL+/6QcWEiovAK/XIJu 5U458bshgi/Ygf2OoDrps0ozJcRPzWqiN/gURtoPV3wj5J02HSkwwvFyCdFZ50Jt fyAWyOvV0CDUE0F5E+hQmlLTF9DFpz08UuwFJSTyzDFnV0knb4iCwHXtJwnTBbKS az2Tklhj9AUxiyVWeYs3LgQ5Rk+cOUrrZ2Bp+zasRiljCjEp6mKHZzoVxUUkpmJR nFUAwg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=8l3Cczc0yj1liMJe7ylAzSnkkR6+gikHqgQtuLlI0 g0=; b=K4UYx+qS+ot/ZZ26eeDIqo8JBn/qVostmYoWcDLnvAGyPucgtYVbMs81F tasQUELOH31jRN2qX0gW6ZmMwZaEsgwMTGKXXGGbkvoN0kZfuMUlCMAIbqIjr9lA 6EVlDY6ee/ga9oky5qJOCVMUUPa5oH0Mt/WxZMtz+ViXw4gUsMgUb+Z9yLSkcf4D 5nSCC0bwZhoIZ32J00q2PIWET5xf5slHBdeDIebOyT1eKi7QM+MOO5hxEdxfEfNr eevMPuHxK5P7AwKO4ZErzt3kx0gsXdeBNib/8osP+InYoagetOJDwKh6u7x7Kosu hCByStv0djuH6U6+l0lW/6I2bmQrw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrgeekgddtlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 2C96E3280063; Thu, 8 Oct 2020 04:46:34 -0400 (EDT) From: Thomas Monjalon To: Liang Ma Cc: dev@dpdk.org, david.hunt@intel.com, stephen@networkplumber.org, konstantin.ananyev@intel.com, Anatoly Burakov , Liang Ma , ferruh.yigit@intel.com, arybchenko@solarflare.com, honnappa.nagarahalli@arm.com, ruifeng.wang@arm.com, jerinj@marvell.com, David Christensen Date: Thu, 08 Oct 2020 10:46:33 +0200 Message-ID: <21651717.U2su3LxMx8@thomas> In-Reply-To: <1601647919-25312-3-git-send-email-liang.j.ma@intel.com> References: <1599214740-3927-1-git-send-email-liang.j.ma@intel.com> <1601647919-25312-1-git-send-email-liang.j.ma@intel.com> <1601647919-25312-3-git-send-email-liang.j.ma@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 03/10] ethdev: add simple power management API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > +/** > + * Retrieve the wake up address from specific queue > + * > + * @param port_id > + * The port identifier of the Ethernet device. > + * @param queue_id > + * The Tx queue on the Ethernet device for which information > + * will be retrieved. > + * @param wake_addr > + * The pointer point to the address which is used for monitoring. > + * @param expected > + * The pointer point to value to be expected when descriptor is set. > + * @param mask > + * The pointer point to comparison bitmask for the expected value. > + * > + * @return > + * - 0: Success. > + * -EINVAL: Failed to get wake address. > + */ > +__rte_experimental > +int rte_eth_get_wake_addr(uint16_t port_id, uint16_t queue_id, > + volatile void **wake_addr, > + uint64_t *expected, uint64_t *mask); It looks to be a very low-level API. Can't we do something more "ready-to-use" at ethdev level? Cc'in the relevant maintainers... Note: sorry this comment come late but ethdev maintainers were not Cc. Reminder: having no feedback is not a good sign, you should request comments.