From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by dpdk.org (Postfix) with ESMTP id 446C9234 for ; Fri, 23 Oct 2015 18:43:38 +0200 (CEST) Received: by wikq8 with SMTP id q8so84881751wik.1 for ; Fri, 23 Oct 2015 09:43:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=DooCnULIf6jn4owXgb4GK1jYcGZx4kekYF7MbZHKS3E=; b=lN/0se3spLFxekDKCdF39ZAq1am0Is7GgzP1D1q3EJ2va9sNkF8lFb7BN5jKY3hm8i fcrBsDPfGnPQZ4V2doTYdjCA0t+okqeYyLC8V0YKuX8hZs04eiAfnOB/SBaEgs2l1zA3 sxduuOGVcj1KQeZWOYSQrhkkHnfyjDlwX9mr21CPpx5kOlH2h1sOI3636xXcSWwJwXOW x8TIp0usSyMn8dPNBX2hQuYM+3T8XEbWCLdfN/1YerBv/4gRXmjQqtHryPaIszTIYM6g VTOqkNvsdwqoNfTQjOOIa4uF9Qs9XMs7YA4ym9TJmzwBCavkF090fKbKU3eKmvcylv+x wD4Q== X-Gm-Message-State: ALoCoQlM+cY2XHAjnY/L1zVnqsjJBVjXKqmWlOOAMW4P06pr70txhdXMJntm1JDMC0G3ImrZ0FzU X-Received: by 10.194.71.16 with SMTP id q16mr5585998wju.49.1445618618087; Fri, 23 Oct 2015 09:43:38 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id w9sm2048117wjf.20.2015.10.23.09.43.37 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 23 Oct 2015 09:43:37 -0700 (PDT) From: Thomas Monjalon To: Harish Patil Date: Fri, 23 Oct 2015 18:42:31 +0200 Message-ID: <2165749.fmlpNCHWa5@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1442018576-19981-1-git-send-email-rasesh.mody@qlogic.com> <9286039.TySdo1XAUF@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, Sony Chacko Subject: Re: [dpdk-dev] [PATCH 2/5] bnx2x: Fix x86_64-native-linuxapp-clang build error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Oct 2015 16:43:38 -0000 2015-10-23 16:36, Harish Patil: > > > >2015-09-11 17:42, Rasesh Mody: > >> #define SHMEM_EEE_ADV_STATUS_MASK 0x00f00000 > >> #define SHMEM_EEE_100M_ADV (1<<0) > >> - #define SHMEM_EEE_1G_ADV (1<<1) > >> + #define SHMEM_EEE_1G_ADV (1U<<1) > >> #define SHMEM_EEE_10G_ADV (1<<2) > > > >Why other constants are not changed? > I only addressed the build error which is against SHMEM_EEE_1G_ADV. > Is that okay? I would say no but you have the ownership on this code. Please think which code quality you are expecting. > This message and any attached documents contain information from the sending company or its parent company(s), subsidiaries, divisions or branch offices that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message. Please remove this footer, irrelevant on a mailing list.