From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 64E9F2935
 for <dev@dpdk.org>; Wed, 25 Oct 2017 00:05:21 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id E1DC120B97;
 Tue, 24 Oct 2017 18:05:20 -0400 (EDT)
Received: from frontend1 ([10.202.2.160])
 by compute1.internal (MEProxy); Tue, 24 Oct 2017 18:05:20 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=UTOuOhdDCHpvMlEFZbLpE/Kcn7
 N7x2ii4ghrYVJ/T48=; b=UYwgOsDhwH1CPnyGdZTGIhHYCZH4OaBLLP06x/Slrd
 hxyxKCpJAbblm/+4ij30SFyBfWsnWpzFhfy+pOFwqG39Plt7vWKRZvLSvtMi+KU9
 s/qIYduw3QDBwrBNFeI9GjZNCCdfe0/lr1SD4MkYGiCXAyj+OX9ExXv8TQE7Ukb0
 I=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=UTOuOh
 dDCHpvMlEFZbLpE/Kcn7N7x2ii4ghrYVJ/T48=; b=dhyc7XJ6XkPr504mP35DrZ
 lpA1pKWuVsdb0QrWdsNe2+UEPHKXofEjfGM0hBs7IoIq3ad2l76zh/ZrNck1QFoR
 AFNt257bfu5sO48H+GgaDAz+tGMoNdefARfNMxFnfyX+Dn2Loc7N5usXi3meLstb
 opKK9NjxYUSgrbl9vvTLA8iVbQIA5NoFWNn+SEIiX5uvqVOu0qzcD4vdE97yc+1J
 iDEZABpFIKLalpM1nBircC+IYiJM0/mhFKgde5ufBiNnO39ijsHfs+kBGmo9AcYO
 XUdZPs4TQ4GEUkXTvXrgCcpL4lL3+5YwdIrWII3k2Bciww9JhLWGh3Vb+/RSQwLg
 ==
X-ME-Sender: <xms:ILnvWUrXAQhDEfTnOFbV9Cj_Aqqp0FpY3GC4cQ_cCEQjjjVscuZM5A>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 9125E7F94E;
 Tue, 24 Oct 2017 18:05:20 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Tomasz Duszynski <tdu@semihalf.com>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>
Date: Wed, 25 Oct 2017 00:05:19 +0200
Message-ID: <2165906.4gmW2yU9sD@xps>
In-Reply-To: <fff0add4-bf1b-50d8-dafc-e6530507cbdc@intel.com>
References: <1508154348-10988-1-git-send-email-tdu@semihalf.com>
 <1508154348-10988-2-git-send-email-tdu@semihalf.com>
 <fff0add4-bf1b-50d8-dafc-e6530507cbdc@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH 1/2] examples/kni: check if pci_dev isn't
	NULL before using it
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Oct 2017 22:05:21 -0000

21/10/2017 02:26, Ferruh Yigit:
> On 10/16/2017 4:45 AM, Tomasz Duszynski wrote:
> > Since virtual devices, i.e mrvl net pmd, do not touch pci_dev
> > dereferencing it will cause segmentation fault as by default
> > it's set to NULL in rte_eth_dev_info_get().
> > 
> > Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Fixed title: examples/kni: check PCI info not NULL before reading

Applied, thanks

The patch 2/2 is left alone as it may be unneeded.