From: Thomas Monjalon <thomas@monjalon.net>
To: Qi Zhang <qi.z.zhang@intel.com>
Cc: dev@dpdk.org, xiaolong.ye@intel.com, ferruh.yigit@intel.com,
arybchenko@solarflare.com, orika@mellanox.com
Subject: Re: [dpdk-dev] [PATCH v4] net/ice: add flow mark hint support
Date: Wed, 20 Nov 2019 19:56:35 +0100 [thread overview]
Message-ID: <2166340.TqaS7Hc55D@xps> (raw)
In-Reply-To: <20191119061442.21369-1-qi.z.zhang@intel.com>
19/11/2019 07:14, Qi Zhang:
> Since not all data paths support flow mark, the driver needs
> a hint from application to select the correct data path if
> flow mark is required. The patch introduces a devarg
> "flow-mark-support" as a workaround solution, since a standard
> way is still ongoing.
>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> Acked-by: Qiming Yang <qiming.yang@intel.com>
> ---
>
> v4:
> - remove debug code, fix typos
>
> v3:
> - add "experimental notification" in ice.rst
>
> v2:
> - fix typos
Please use --in-reply-to to help tracking all the versions together.
> +- ``Flow Mark Support`` (default ``0``)
> +
> + This is a hint to the driver to select the data path that supports flow mark extraction
> + by default.
> + NOTE: This is an experimental devarg, it will be removed when any of below conditions
> + is ready.
> + 1) all data paths support flow mark (currently vPMD does not)
> + 2) a new offload like RTE_DEV_RX_OFFLOAD_FLOW_MARK be introduced as a standard way to hint.
When the data path is selected?
I suppose such decision should be done when starting the port,
after everything is configured.
So you can check if a rte_flow rule was added for mark action.
Why the user needs to use an explicit option?
next prev parent reply other threads:[~2019-11-20 18:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 6:14 Qi Zhang
2019-11-19 6:34 ` Ye Xiaolong
2019-11-20 18:56 ` Thomas Monjalon [this message]
2019-11-21 1:19 ` Zhang, Qi Z
2019-11-21 7:36 ` Thomas Monjalon
2019-11-21 12:40 ` Zhang, Qi Z
2019-11-21 21:05 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2166340.TqaS7Hc55D@xps \
--to=thomas@monjalon.net \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=orika@mellanox.com \
--cc=qi.z.zhang@intel.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).