* [dpdk-dev] [PATCH] app/testpmd: disable latency stats by default
@ 2017-05-02 13:11 Pablo de Lara
2017-05-02 13:11 ` De Lara Guarch, Pablo
2017-05-04 16:28 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
0 siblings, 2 replies; 5+ messages in thread
From: Pablo de Lara @ 2017-05-02 13:11 UTC (permalink / raw)
To: jingjing, reshma.pattan; +Cc: dev, Pablo de Lara
Disable latency stats gathering by default,
so there is not performance degradation if user
is not interested in them.
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
app/test-pmd/testpmd.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index dfe6442..23dfdb0 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -971,7 +971,8 @@ run_pkt_fwd_on_lcore(struct fwd_lcore *fc, packet_fwd_t pkt_fwd)
}
#endif
#ifdef RTE_LIBRTE_LATENCY_STATS
- if (latencystats_lcore_id == rte_lcore_id())
+ if (latencystats_enabled != 0 &&
+ latencystats_lcore_id == rte_lcore_id())
rte_latencystats_update();
#endif
@@ -2238,8 +2239,9 @@ main(int argc, char** argv)
rte_panic("Empty set of forwarding logical cores - check the "
"core mask supplied in the command parameters\n");
- /* Bitrate stats disabled by default */
+ /* Bitrate/latency stats disabled by default */
bitrate_enabled = 0;
+ latencystats_enabled = 0;
argc -= diag;
argv += diag;
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: disable latency stats by default
2017-05-02 13:11 [dpdk-dev] [PATCH] app/testpmd: disable latency stats by default Pablo de Lara
@ 2017-05-02 13:11 ` De Lara Guarch, Pablo
2017-05-04 16:28 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
1 sibling, 0 replies; 5+ messages in thread
From: De Lara Guarch, Pablo @ 2017-05-02 13:11 UTC (permalink / raw)
To: Pattan, Reshma; +Cc: dev, Wu, Jingjing
CC'ing Jingjing.
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Tuesday, May 02, 2017 2:11 PM
> To: jingjing@intel.com; Pattan, Reshma
> Cc: dev@dpdk.org; De Lara Guarch, Pablo
> Subject: [PATCH] app/testpmd: disable latency stats by default
>
> Disable latency stats gathering by default,
> so there is not performance degradation if user
> is not interested in them.
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
> app/test-pmd/testpmd.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index dfe6442..23dfdb0 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -971,7 +971,8 @@ run_pkt_fwd_on_lcore(struct fwd_lcore *fc,
> packet_fwd_t pkt_fwd)
> }
> #endif
> #ifdef RTE_LIBRTE_LATENCY_STATS
> - if (latencystats_lcore_id == rte_lcore_id())
> + if (latencystats_enabled != 0 &&
> + latencystats_lcore_id == rte_lcore_id())
> rte_latencystats_update();
> #endif
>
> @@ -2238,8 +2239,9 @@ main(int argc, char** argv)
> rte_panic("Empty set of forwarding logical cores - check the
> "
> "core mask supplied in the command
> parameters\n");
>
> - /* Bitrate stats disabled by default */
> + /* Bitrate/latency stats disabled by default */
> bitrate_enabled = 0;
> + latencystats_enabled = 0;
>
> argc -= diag;
> argv += diag;
> --
> 2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-dev] [PATCH v2] app/testpmd: disable latency stats by default
2017-05-02 13:11 [dpdk-dev] [PATCH] app/testpmd: disable latency stats by default Pablo de Lara
2017-05-02 13:11 ` De Lara Guarch, Pablo
@ 2017-05-04 16:28 ` Pablo de Lara
2017-05-06 1:10 ` Wu, Jingjing
1 sibling, 1 reply; 5+ messages in thread
From: Pablo de Lara @ 2017-05-04 16:28 UTC (permalink / raw)
To: jingjing.wu, reshma.pattan; +Cc: dev, Pablo de Lara
Disable latency stats gathering by default,
so there is not performance degradation if user
is not interested in them.
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
This patch depends on http://dpdk.org/dev/patchwork/patch/24064/
app/test-pmd/testpmd.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 776b8dd..0a4f15d 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -971,7 +971,8 @@ run_pkt_fwd_on_lcore(struct fwd_lcore *fc, packet_fwd_t pkt_fwd)
}
#endif
#ifdef RTE_LIBRTE_LATENCY_STATS
- if (latencystats_lcore_id == rte_lcore_id())
+ if (latencystats_enabled != 0 &&
+ latencystats_lcore_id == rte_lcore_id())
rte_latencystats_update();
#endif
@@ -2238,10 +2239,13 @@ main(int argc, char** argv)
rte_panic("Empty set of forwarding logical cores - check the "
"core mask supplied in the command parameters\n");
- /* Bitrate stats disabled by default */
+ /* Bitrate/latency stats disabled by default */
#ifdef RTE_LIBRTE_BITRATE
bitrate_enabled = 0;
#endif
+#ifdef RTE_LIBRTE_LATENCY_STATS
+ latencystats_enabled = 0;
+#endif
argc -= diag;
argv += diag;
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH v2] app/testpmd: disable latency stats by default
2017-05-04 16:28 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
@ 2017-05-06 1:10 ` Wu, Jingjing
2017-05-06 7:38 ` Thomas Monjalon
0 siblings, 1 reply; 5+ messages in thread
From: Wu, Jingjing @ 2017-05-06 1:10 UTC (permalink / raw)
To: De Lara Guarch, Pablo, Pattan, Reshma; +Cc: dev
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Friday, May 5, 2017 12:29 AM
> To: Wu, Jingjing <jingjing.wu@intel.com>; Pattan, Reshma
> <reshma.pattan@intel.com>
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [PATCH v2] app/testpmd: disable latency stats by default
>
> Disable latency stats gathering by default, so there is not performance
> degradation if user is not interested in them.
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Jingjing Wu <jingjing.wu@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH v2] app/testpmd: disable latency stats by default
2017-05-06 1:10 ` Wu, Jingjing
@ 2017-05-06 7:38 ` Thomas Monjalon
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2017-05-06 7:38 UTC (permalink / raw)
To: De Lara Guarch, Pablo; +Cc: dev, Wu, Jingjing, Pattan, Reshma
06/05/2017 03:10, Wu, Jingjing:
>
> From: De Lara Guarch, Pablo
> >
> > Disable latency stats gathering by default, so there is not performance
> > degradation if user is not interested in them.
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> Acked-by: Jingjing Wu <jingjing.wu@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-05-06 7:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-02 13:11 [dpdk-dev] [PATCH] app/testpmd: disable latency stats by default Pablo de Lara
2017-05-02 13:11 ` De Lara Guarch, Pablo
2017-05-04 16:28 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
2017-05-06 1:10 ` Wu, Jingjing
2017-05-06 7:38 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).