From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 8D195A056A;
	Fri,  6 Mar 2020 10:06:09 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id E01C11BFD6;
	Fri,  6 Mar 2020 10:06:08 +0100 (CET)
Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com
 [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id 137F81BFD2
 for <dev@dpdk.org>; Fri,  6 Mar 2020 10:06:07 +0100 (CET)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47])
 by mailnew.nyi.internal (Postfix) with ESMTP id 5F5E82A85;
 Fri,  6 Mar 2020 04:06:06 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute7.internal (MEProxy); Fri, 06 Mar 2020 04:06:06 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=mesmtp;
 bh=K03E+3Sgl+ZsxUGcS6soFUVb4auUCvFMHBDAr9g3l4s=; b=HGeqza/0WXmx
 hnpExyDKrauquUXpA3RuwROCssgwriGr+sGgXWRQiXLdmzNhAo1ycjbyMCNLohKP
 HRxF/V6JGT9buHSoJDBXiT6cBoCspNolJmvRqGBjX1NrP6q+JIoXi3+SQW/aKJZE
 KSCrJS1NCTsUz6oPu/0D4HomHI/BWSc=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm2; bh=K03E+3Sgl+ZsxUGcS6soFUVb4auUCvFMHBDAr9g3l
 4s=; b=ZXfbtQecNGQ2JeT40FeuS5yye6LFk9NIJfbuGrdsXqCLc6yMFP82TB1ek
 WUgeAoBD0sz4mEuRcJj4w4WSly4MS1EgQPT5zCHn7+P/0JoXPGSlX4+kwxQFB77y
 FdTFfITAhbWxsDV0hpwXey2/w3nedhKUrHpqFt28jdVwrFPmabkvnYlU/SDuG1a8
 gHquOd5i5gvgTG/RulfW2m0B1jRnFseRuzn2C201iLyltjhwd/FKbKGEAjkS/MEH
 Nk76my/Y5wN+fRoXlOrfXwsrwz2HE1ifKZQP5hKg+7hu8GMMcAExIoqpC5Sp/sZ0
 UzMo6gvFxsZdphszKE4bKdYoTi2Kw==
X-ME-Sender: <xms:fRJiXrdTXIGlfdin8aeYnoyH3Dt8UDBF3u1ESNLZkaj-KDQ-nT-PHQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudduvdcutefuodetggdotefrodftvfcurf
 hrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecuuegr
 ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug
 hrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghsucfo
 ohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffohhmrg
 hinhephhhurghrmhdrtghomhenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehl
 uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghsse
 hmohhnjhgrlhhonhdrnhgvth
X-ME-Proxy: <xmx:fRJiXhfE27CUKxVKNVKwWDYEaDSrbWXP_l9YMAblLDcWXa_e5vLsQQ>
 <xmx:fRJiXtbaIfEHTb9wNirP0hPeow3In6R9dX8jvrPAMllZY7l1PZ1qQw>
 <xmx:fRJiXg1WvJkyFwd1QkiEgpC2Rs0Maps53-VXt36AemIe7MROCSq_BQ>
 <xmx:fhJiXtYS9MPzbQoo2Mt8ZcDXQQIkcERyg-TrBMZ15nj7rnelGcO8fg>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 18D8E3060BD1;
 Fri,  6 Mar 2020 04:06:04 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Gavin Hu <gavin.hu@arm.com>, Jerin Jacob <jerinjacobk@gmail.com>
Cc: dpdk-dev <dev@dpdk.org>, nd <nd@arm.com>,
 David Marchand <david.marchand@redhat.com>, Jerin Jacob <jerinj@marvell.com>,
 "Ye, Xiaolong" <xiaolong.ye@intel.com>,
 Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
 "Ruifeng Wang (Arm Technology China)" <ruifeng.wang@arm.com>,
 Phil Yang <phil.yang@arm.com>, Joyce Kong <joyce.kong@arm.com>,
 Steve Capper <steve.capper@arm.com>
Date: Fri, 06 Mar 2020 10:06:03 +0100
Message-ID: <2168979.ECZNHGQPT7@xps>
In-Reply-To: <CALBAE1Om8CE=SZVF4J88d=VFAAK9j2xMSOB81j5nzFAchA-uEQ@mail.gmail.com>
References: <20200306050427.66114-1-gavin.hu@arm.com>
 <20200306050427.66114-4-gavin.hu@arm.com>
 <CALBAE1Om8CE=SZVF4J88d=VFAAK9j2xMSOB81j5nzFAchA-uEQ@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v1 3/3] net/i40e: auto-vectorization to speed
	up Tx free
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

06/03/2020 08:44, Jerin Jacob:
> On Fri, Mar 6, 2020 at 10:35 AM Gavin Hu <gavin.hu@arm.com> wrote:
> > --- a/drivers/net/i40e/i40e_rxtx_vec_common.h
> > +++ b/drivers/net/i40e/i40e_rxtx_vec_common.h
> > @@ -98,6 +98,11 @@ i40e_tx_free_bufs(struct i40e_tx_queue *txq)
> >         if (likely(m != NULL)) {
> >                 free[0] = m;
> >                 nb_free = 1;
> > +#if defined(__clang__)
> > +#pragma clang loop vectorize(assume_safety)
> > +#elif defined(__GNUC__)
> > +#pragma GCC ivdep
> > +#endif
> 
> IMO, It is better to abstract the compiler features  (above compiler
> feature and __restrict__) as macros in
> rte_common.h or so. It will help to support other compilers(ICC or
> Windows) and enable them to have "changes" in one place.

I agree with the need for common abstraction.